Tracking Issue - Some words are not handled well for Model names (Pluralization, ect) and reserved words

[johannpinson]

Edited by @derrickmehaffy on 2021/03/29

This issue has been converted to a global tracking issue regarding certain english or other language words that fail to work when building models. There are various examples, and for the moment the workarounds mean excluding these words from use and doing things like:

news => newsItem ect

---

Informations

• Node.js version: 8.9.1
• npm version: 5.6.0
• Strapi version: 3.0.0-alpha.12.1.3
• Database: Mongo v3.4.9
• Operating system: MacOS 10.13.4

What is the current behavior?
When I create a new content type with a name which have the same plural version, the API generate will loop into a 500

Steps to reproduce the problem

• Create a new content type named "Fish" (or "News")
• Use a GraphQL IDE or look the terminal
  

What is the expected behavior?
The problem is that some english words have a specific plural behavior (like child/children) or have the same orthograph
As example : https://github.com/atteo/evo-inflector/blob/master/src/main/java/org/atteo/evo/inflector/English.java#L131

Suggested solutions

Best solution:
Disallow to use "words" which can have an different plural/single mode (ex: fish, news, etc.)

Another solution is to add a flag "all" in front, a.k.a "allFish" (but it add a 2nd behavior so i don't think it's the best solution

---

• I'm sure that this feature hasn't already been referenced.

[Aurelsicoko]

Great question... It's complicated because we're going to follow the OpenCRUD specs and this case doesn't seem to be handled. I'm going to ask how we should deal with this case.

[johannpinson]

I know, i already have the problem with Prisma (who manages the OpenCRUD docs) about this problem: prisma/prisma1#1772
In fact, the use a scala library to detect singular/plural words and blocks some of them.

[Aurelsicoko]

@johannpinson Thank you for sharing the issue on Prisma. I think the OpenCRUD specs could evolve for fixing that kind of issues. I'm not sure that excluding words is the right way to solve it. How many words are concerned by it?

[johannpinson]

@Aurelsicoko
Actually, Prisma blocks words which are invariable.

And in the OpenCRUD doc, it talks about using the java library evo-inflector (because Prisma is built with Scala/Sangria) and it lists 51 words invariable.

Moreover, it looks like Strapi use the pluralize lib, so we can detect if the word have a plural way.

[Aurelsicoko]

I understand but blocking words is not an optimal solution because as a workaround we can add the prefix all for these words or change the specs to make sure the plural queries are harmonized whatever the word used. It should be specified in the specs.

[MartinMuzatko]

Have the same problem.

I get the following stack trace:

[2018-08-15T14:48:37.214Z] debug POST /graphql (7 ms)
Error: Field Query.species can only be defined once.
    at assertValidSchema (~test/plugins/graphql/node_modules/graphql/type/validate.js:82:11)
    at Object.validate (~test/plugins/graphql/node_modules/graphql/validation/validate.js:58:35)
    at doRunQuery (~test/plugins/graphql/node_modules/apollo-server-core/dist/runQuery.js:111:42)
    at ~test/plugins/graphql/node_modules/apollo-server-core/dist/runQuery.js:21:56
    at process._tickCallback (internal/process/next_tick.js:68:7)
[2018-08-15T14:48:40.397Z] debug POST /graphql (10 ms)

[Aurelsicoko]

@MartinMuzatko Try to find another word for this model until we find a viable solution.

[MartinMuzatko]

Sure - already did. I just hate to abuse the english language @Aurelsicoko

[kret13]

Any update on this seems News keyword cant still be used as content type name?