[v4] Filters in `findOne` controller doesn't work

[abdonrd]

Bug report

Describe the bug

Filters in findOne controller doesn't work.

Steps to reproduce the behavior

1. Create a controller like this:

async findOne(ctx) {
  // Filter by the current user as the author
  ctx.query = {
    ...ctx.query,
    filters: {
      author: {
        id: ctx.state.user.id
      }
    },
  };

  const response = await super.findOne(ctx);

  return response;
},

2. Run the REST GET /content-type/:id
3. It shows the entry, even if the user is not the author

Expected behavior

The custom filter working

System

• Node.js version: v14
• NPM version: v8
• Strapi version: v4.0.4
• Database: SQLite
• Operating system: macOS

Additional context

Debugging a bit...

After this:

strapi/packages/core/strapi/lib/core-api/service/collection-type.js

Lines 54 to 56 in 31259db

	findOne(entityId, params = {}) {
	return strapi.entityService.findOne(uid, entityId, this.getFetchParams(params));
	},

I see that this line removes the custom params:

strapi/packages/core/strapi/lib/services/entity-service/index.js

Line 144 in 31259db

const query = transformParamsToQuery(uid, pickSelectionParams(wrappedParams));

[kasonde]

Hi, thanks for the question. I'm closing this here however since it's not an issue but a question that is absolutely perfect for our Community Forum. Once you post it there, I and other community members will be happy to share our ideas.

You filter must look like this in Strapi v4. Hope this helps!

ctx.query = {
    ...ctx.query,
    filters: {
      author: {
        id: {
          $eq: ctx.state.user.id
        }
      }
    },
  };

[abdonrd]

The documentation that you link says:

$eq can be omitted:

Anyway, the code you have proposed doesn't work either.

[abdonrd]

And I think this is not a question, it's a bug.

Debugging a bit...

After this:

strapi/packages/core/strapi/lib/core-api/service/collection-type.js

Lines 54 to 56 in 31259db

	findOne(entityId, params = {}) {
	return strapi.entityService.findOne(uid, entityId, this.getFetchParams(params));
	},

I see that this line removes the custom params:

strapi/packages/core/strapi/lib/services/entity-service/index.js

Line 144 in 31259db

const query = transformParamsToQuery(uid, pickSelectionParams(wrappedParams));

[abdonrd]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @strapi/strapi@4.0.4 for the project I'm working on.

I just tried to fix #12208.

Here is the diff that solved my problem:

diff --git a/node_modules/@strapi/strapi/lib/services/entity-service/index.js b/node_modules/@strapi/strapi/lib/services/entity-service/index.js
index 20a40c7..1815d56 100644
--- a/node_modules/@strapi/strapi/lib/services/entity-service/index.js
+++ b/node_modules/@strapi/strapi/lib/services/entity-service/index.js
@@ -141,9 +141,9 @@ const createDefaultImplementation = ({ strapi, db, eventHub, entityValidator })
   async findOne(uid, entityId, opts) {
     const wrappedParams = await this.wrapParams(opts, { uid, action: 'findOne' });
 
-    const query = transformParamsToQuery(uid, pickSelectionParams(wrappedParams));
+    const query = transformParamsToQuery(uid, wrappedParams);
 
-    return db.query(uid).findOne({ ...query, where: { id: entityId } });
+    return db.query(uid).findOne({ ...query, where: { ...query.where, id: entityId } });
   },
 
   async count(uid, opts) {

This issue body was partially generated by patch-package.

[Webbist-dev]

I agree this should be a thing. I'd like to filter on more than the id (if routing via slug in my frontend)

[abdonrd]

I just create a PR: #12223

[abdonrd]

@kasonde could you reopen the issue? Thanks!

[kasonde]

@abdonrd thanks for the extra information.