Unnecessary warning for AWS S3 provider plugin

[swapzone]

Bug report

Required System information

• Node.js version: v18.14.1
• NPM version: 9.3.1
• Strapi version: 4.9.1
• Database: MySQL
• Operating system: MacOS Ventura 13.3.1
• Is your project Javascript or Typescript: Javascript

Describe the bug

When starting the Strapi server, there is a warning in the console:

Warning: S3 configuration options passed at root level of the plugin's providerOptions is deprecated and will be removed in a future release. Please wrap them inside the 's3Options:{}' property.

Steps to reproduce the behavior

1. Add the AWS S3 Provider Plugin
2. Configure the plugin as described here: https://market.strapi.io/providers/@strapi-provider-upload-aws-s3
3. Start the Strapi server.

Expected behavior

I would expect the warning not to be there, when I configure the AWS S3 plugin as described in the docs.

Additional context

I was stumbling across the following line of code:

strapi/packages/providers/upload-aws-s3/lib/index.js

Line 22 in dec9156

if (legacyS3Options) {

legacyS3Options will always be an object and so this check will always be true. I would suggest a check like Object.keys(legacyS3Options).length > 0 instead to only show the warning, when there are options in the old legacy format.

[github-actions]

This is a templated message

Hello @swapzone,

We ask that you please follow the issue template.
A proper issue submission let's us better understand the origin of your bug and therefore help you. We will reopen your issue when we receive the issue following the template guidelines and properly fill out the template. You can see the template guidelines for bug reports here.

Please update the issue with the template and we can reopen this report.

Thank you.

[strapi-bot]

This issue has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/how-do-i-make-the-s3options-warning-go-away/27409/3

[Marc-Roig]

Hello :)
This should be fixed in https://github.com/strapi/strapi/pull/16323/files#diff-ce07d128a6bfc46461b45013da346cbd265761dd6e99e11fec52050ffe4d5665R49
this will be released next week.

[swapzone]

Thanks for the info, Marc!

[aybasaran]

Hi There, Nothing changed?

[rafaelmelope]

@Marc-Roig the release is deployed? I updated the strapi version ans I still have the warning here.

[derrickmehaffy]

@Marc-Roig the release is deployed? I updated the strapi version ans I still have the warning here.

No today's release was a hotfix, we do normal releases on Wednesdays

[kashif-ghafoor]

Any update on this issue. I am still getting warning

(node:216163) Warning: S3 configuration options passed at root level of the plugin's providerOptions is deprecated and will be removed in a future release. Please wrap them inside the 's3Options:{}' property.

strapi version:4.15.0
provider-upload-aws-s3: ^4.15.0

[kashif-ghafoor]

Moving all configurations from providerOptions to s3Options solved the issue. Here is my working config which doesn't give warning,

{
    upload: {
      config: {
        provider: "aws-s3",
        providerOptions: {
          s3Options: {
            accessKeyId: env("AWS_S3_ACCESS_KEY_ID", ""),
            secretAccessKey: env("AWS_S3_SECRET_ACCESS_KEY", ""),
            region: env("AWS_S3_REGION", "us-east-1"),
            params: {
              Bucket: env("AWS_S3_BUCKET"),
              ACL: env("AWS_S3_ACL", "private"),
            },
            baseUrl: env("AWS_S3_CDN_URL"), 
          },
        },
      },
    }
}

[aybasaran]

Moving all configurations from providerOptions to s3Options solved the issue. Here is my working config which doesn't give warning,

{
    upload: {
      config: {
        provider: "aws-s3",
        providerOptions: {
          s3Options: {
            accessKeyId: env("AWS_S3_ACCESS_KEY_ID", ""),
            secretAccessKey: env("AWS_S3_SECRET_ACCESS_KEY", ""),
            region: env("AWS_S3_REGION", "us-east-1"),
            params: {
              Bucket: env("AWS_S3_BUCKET"),
              ACL: env("AWS_S3_ACL", "private"),
            },
            baseUrl: env("AWS_S3_CDN_URL"), 
          },
        },
      },
    }
}

This is not working!!!!!!!!!!!!!!

[redondi88]

This fixed it for me:

s3Options:{
            credentials:{
              accessKeyId: env('AWS_ACCESS_KEY_ID'),
              secretAccessKey: env('AWS_ACCESS_SECRET'),
            },
            region: env('AWS_REGION'),
            params: {
              ACL: 'private', // <== set ACL to private
              signedUrlExpires: env('AWS_SIGNED_URL_EXPIRES', 60 * 60 * 24 * 7),
              Bucket: env('AWS_BUCKET'),
            },
          },

[anuj-scanova]

The documentation itself does not reflect the valid configuration
https://github.com/strapi/strapi/tree/develop/packages/providers/upload-aws-s3

[Haxen2000]

This fixed it for me:

s3Options:{
            credentials:{
              accessKeyId: env('AWS_ACCESS_KEY_ID'),
              secretAccessKey: env('AWS_ACCESS_SECRET'),
            },
            region: env('AWS_REGION'),
            params: {
              ACL: 'private', // <== set ACL to private
              signedUrlExpires: env('AWS_SIGNED_URL_EXPIRES', 60 * 60 * 24 * 7),
              Bucket: env('AWS_BUCKET'),
            },
          },

This did it for me. I went from

upload: {
    config: {
      provider: 'aws-s3',
      providerOptions: {
        accessKeyId: env('AWS_ACCESS_KEY_ID'),
        secretAccessKey: env('AWS_ACCESS_SECRET'),
        region: env('AWS_REGION'),...

to

upload: {
    config: {
      provider: 'aws-s3',
      providerOptions: {
        s3Options: {
          credentials: {
            accessKeyId: env('AWS_ACCESS_KEY_ID'),
            secretAccessKey: env('AWS_ACCESS_SECRET'),
          },
          region: env('AWS_REGION'),...

Without the credentials, I had an additional error: Credentials passed directly to s3Options is deprecated`