Controller update method is not called from the admin panel

[gregg-cbs]

Bug report

Required System information

• Strapi version: 4.13.6
• Database: Postgres
• Operating system:

Describe the bug

When extending a controllers update method, the method is called via rest api but not when updating content in the admin panel.

Steps to reproduce the behavior

1. Create a collection in the admin panel
2. Add update method to the collections controller in code
3. Create content in the collection and then update some content in the admin panel
4. Notice the update method does not fire
5. Make a PUT rest api request to the route and notice the update method does fire

Expected behavior

Expect the update controller to run anytime content is updated. Not only via specific entry points like rest api.

Code snippets

export default factories.createCoreController('api::event.event', ({ strapi }) => ({
    async update(ctx){
      console.log("Does not run when saving content in the admin panel")
   }
}))

Additional context

Forum discussion raised by other members here https://forum.strapi.io/t/override-controller-services-not-working-in-admin-panel-v4/13997

[strapi-bot]

This issue has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/override-controller-services-not-working-in-admin-panel-v4/13997/10

[avdhendra]

can i work on this issue

[Sadaf-A]

Greetings @gregg-cbs , I would like to work on this if you could please assign me

[Boegie19]

The code snippet is working as intended.

export default factories.createCoreController('api::event.event', ({ strapi }) => ({
    async update(ctx){
      console.log("Does not run when saving content in the admin panel")
   }
}))

if you want the behavior you want and for update to call the original update you do

export default factories.createCoreController('api::event.event', ({ strapi }) => ({
    async update(ctx){
      await super.update(ctx)
   }
}))

or call the entity service

export default factories.createCoreController('api::event.event', ({ strapi }) => ({
    async update(ctx){
      await strapi.entityService.update()
   }
}))

[gregg-cbs]

@Boegie19 - I understand the updating part. I get how calling super.update will run the actual query. I am not referring to that.

I am saying that the update controller does not run at all when doing updates from the admin panel but it does run when doing updates from rest api. Its almost as if the admin panel does updates another way that doesnt go through the extended controller. This has happened with different collections too, its not just a specific collection.

I will need to find a way to show this to you. I will make a screen recording today.

[Boegie19]

@gregg-cbs Looking at the code you are right.
https://github.com/strapi/strapi/blob/main/packages/core/content-manager/server/services/entity-manager.js#L113-L126

still the code is working as intended since we don't what changes to a service to affect the admin when not meant to. that is why it skips the service and goes directly to the entity-service. if you want this to be changed You would have to open a an enchant request in https://feedback.strapi.io/

[gregg-cbs]

This is confusing though...

So if do what the documentation says:

This will not apply to admin panel?
But rest and graph will be affected?

So are you confirming that if I extended a core controller crud operation as mentioned in the documentation and screenshot above, this will not affect crud operations that happen from the admin panel and only the rest and graph api?

Does this mean in order to intercept crud operations in admin and rest api I have use lifecycle hooks?

[Boegie19]

@gregg-cbs Correct. You need to be entity-service or lower.
the admin pannel has its fully own api. controller and services.

[gregg-cbs]

What is your recommendation?
I want a place where i can put my core domain/collection logic for my crud operations so that it will run whether admin or api does cruds.

Can i extend an entity service?
Or do i put my logic in lifecycle hooks? that feels weird.

[Boegie19]

@gregg-cbs entity service is extendable but is not documented there for I would go with lifecycle hooks

[gregg-cbs]

thanks for your time, i really appreciate it. This is unfortunately not the outcome i was hoping for :(

[Boegie19]

@gregg-cbs It really depends on the logic you want if you want to we can do a vc to understand more of your use cease and then I can maybe give an better answer.