/upload return the url contains `localhost:1337` after migrate from beta.13 to beta.17.8

[ly525]

Describe the bug
when the strapi version is: 3.0.0-beta.13,
the /upload respnse is

[
    {
        "id": 1875,
        "name": "RjQkhE3OsrVv7uz.png",
        "hash": "b2c665392e044e7fb81019df4d4cd035",
        "sha256": "kfiz-6Iuc-Pcn3OCDn-Co1xCd9ieemgxSF56LYGqC5M",
        "ext": ".png",
        "mime": "image/png",
        "size": "222.58",
        "url": "/uploads/b2c665392e044e7fb81019df4d4cd035.png",
        "provider": "local",
        "provider_metadata": null,
        "created_at": "2019-12-21T14:36:17.716Z",
        "updated_at": "2019-12-21T14:36:17.716Z",
        "related": []
    }
]

but when I upgrade the strapi version to 3.0.0-beta.17.8
the /upload response is

[
    {
        "id": 1875,
        "name": "RjQkhE3OsrVv7uz.png",
        "hash": "b2c665392e044e7fb81019df4d4cd035",
        "sha256": "kfiz-6Iuc-Pcn3OCDn-Co1xCd9ieemgxSF56LYGqC5M",
        "ext": ".png",
        "mime": "image/png",
        "size": "222.58",
        "url": "http://localhost:1337/uploads/b2c665392e044e7fb81019df4d4cd035.png",
        "provider": "local",
        "provider_metadata": null,
        "created_at": "2019-12-21T14:36:17.716Z",
        "updated_at": "2019-12-21T14:36:17.716Z",
        "related": []
    }
]

Steps to reproduce the behavior

1. upload image then get http://localhost:1337/uploads/xxx.png

1. git clone https://github.com/ly525/luban-h5
2. cd back-end/h5-api && yarn && yarn dev
3. visit http://localhost:1337/admin/
4. upload image from the admin panel
5. you will see the image url is http://localhost:1337/uploads/xxx.png

2. upload image then get /uploads/xxx.png

6. git checkout fad25b8 # the strapi dependencies is beta.13 in this commit
7. rm -rf node_modules && yarn && yarn dev
8. visit http://localhost:1337/admin/
9. upload image from the admin panel
10. you will see the image url is http://localhost:1337/uploads/xxx.png

Expected behavior

1. this breaks my online product and makes me confused.

2. I do not want to config proxy in server.json and want to get {url: '/uploads/xxx.png'}, could you please do not add the host prefix url to the image url, because:

   • the host domain may change(many customers may use my product powered by strapi and they have their domain
   • we will save the image url to the database.

3. Can strapi provide an option to keep the relative image path as before)

4. may you please revert to {url: '/uploads/xxx.png'}? thanks a lot!

Screenshots

Code snippets
If applicable, add code samples to help explain your problem.

System

• Node.js version: v12.13.0
• NPM version: 6.12.0
• Strapi version: 3.0.0-beta.17.8
• Database: sqlite3
• Operating system: Mac & Centos7

[derrickmehaffy]

This is a templated message

Hello, please follow the issue template.

A proper issue submission let's us better understand the origin of your bug and therefore help you.

I will reopen your issue when we receive the issue following the template guidelines and properly fill out the template.

Please update the issue.

Thank you.

A copy of the bug report template can be found below:

<!--
Hello 👋 Thank you for submitting an issue.

Before you start, please make sure your issue is understandable and reproducible.
To make your issue readable make sure you use valid Markdown syntax.

https://guides.github.com/features/mastering-markdown/
-->

**Describe the bug**
A clear and concise description of what the bug is.

**Steps to reproduce the behavior**
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Code snippets**
If applicable, add code samples to help explain your problem.

**System**
- Node.js version: <!-- Please ensure you are using the Node LTS version (v10) -->
- NPM version:
- Strapi version: <!-- Please make sure you are on the latest version -->
- Database:
- Operating system:

**Additional context**
Add any other context about the problem here.

[ly525]

@derrickmehaffy thanks, I have already updated the issue

[derrickmehaffy]

Reopening, thank you for updating it

[lauriejim]

I ping @alexandrebodin and @Aurelsicoko for this topic!

[alexandrebodin]

Actually this isn't a change we made recently. This is old code that just got fixed. I agree that we shouldn't add the domain part. Will do a fix for that.

[ly525]

Actually this isn't a change we made recently. This is old code that just got fixed. I agree that we shouldn't add the domain part. Will do a fix for that.

Thanks for your understanding and the next work

[abdonrd]

Actually this isn't a change we made recently. This is old code that just got fixed. I agree that we shouldn't add the domain part. Will do a fix for that.

@alexandrebodin @lauriejim Sorry to relive this old issue, but...

Why shouldn't the URL be prefixed?

In this way... When displaying the images from a web application:

• It work if we setup a provider like Cloudinary or so (because the absolute URL).
• It doesn't work if we setup the local provider (because the relative URL).

I think the behavior should be the same regardless of the provider you are using.
The web application shouldn't have to worry about whether the URL is coming from one site or another.

[abdonrd]

Meanwhile, from where could this logic change?
I am not clear where I could change this behavior with the current structure of the plugin.

We always get the files/images from GrahpQL queries.