Skip to content

Conversation

@badsyntax
Copy link

Lodash _.lowerCase will remove any dashes/underscores and this is not the desired behaviour.

What does it do?

It fixes this bug: #10524

Why is it needed?

To fix this bug: #10524

How to test it?

There's no unit tests, so i manually tested it by replacing the contents of node_modules/strapi-plugin-documentation/services/Documentation.js with the changes in this PR, then re-generated the API and now the API docs are showing the correct response:

responses": {
    "200": {
    "description": "Retrieve aaa-aa document(s)",
    "content": {
        "application/json": {
            "schema": {
                "type": "array",
                "items": {
                    "$ref": "#/components/schemas/Aaa-aa"
                }
            }
        }
    }
},

Related issue(s)/PR(s)

#10524

Lodash _.lowerCase will remove any dashes/underscores and this is not the desired behaviour.
@strapi-cla
Copy link

strapi-cla commented Jun 23, 2021

CLA assistant check
All committers have signed the CLA.

@badsyntax badsyntax changed the title Don't use lodash lowerCase. Fixes #10524 documentation plugin: Don't use lodash lowerCase. Fixes #10524 Jun 23, 2021
@derrickmehaffy
Copy link
Member

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/are-strapi-maintainers-accepting-pull-requests/9157/1

@derrickmehaffy
Copy link
Member

Hi 👋
We now have released the v4. As of now, the v3 is in maintenance mode for 6 months. We will only be fixing critical and security issues on v3 from now on.
I will go ahead and close this PR. Thank you for contributing to Strapi 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants