Skip to content

Conversation

@derrickmehaffy
Copy link
Member

What does it do?

Adds the default created_at and updated_at to the admin user model.

Why is it needed?

Honestly I have no idea why we never had it to begin with, makes it much easier to do automated tasks on admin users via cronjobs like setting registration codes to expire on a cronjob. See: https://forum.strapi.io/t/how-to-make-the-registration-link-expire/11260/3

How to test it?

Spin up a project and check that the fields exist with data when you register a user

Related issue(s)/PR(s)

https://forum.strapi.io/t/how-to-make-the-registration-link-expire/11260

Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
@derrickmehaffy derrickmehaffy added the issue: feature request Issue suggesting a new feature label Sep 10, 2021
@derrickmehaffy
Copy link
Member Author

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/how-to-make-the-registration-link-expire/11260/4

@derrickmehaffy derrickmehaffy added source: core:admin Source is core/admin package and removed issue: feature request Issue suggesting a new feature labels Sep 10, 2021
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #10937 (f58118c) into master (d91569c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10937   +/-   ##
=======================================
  Coverage   58.12%   58.12%           
=======================================
  Files         185      185           
  Lines        6429     6429           
  Branches     1395     1395           
=======================================
  Hits         3737     3737           
  Misses       2230     2230           
  Partials      462      462           
Flag Coverage Δ
front ?
unit 58.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91569c...f58118c. Read the comment docs.

@alexandrebodin
Copy link
Member

the timestamps option doesn't exist anymore

@alexandrebodin alexandrebodin deleted the feature/adminUserTimestamps branch September 15, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

source: core:admin Source is core/admin package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants