-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Unify provider READMEs and add CSP Config examples for Upload #11750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+411
−107
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
20994a4
Finish fixing the email provider readmes
derrickmehaffy b007aff
Unify provider READMEs and add Upload CSP config examples
derrickmehaffy 81c3272
Merge branch 'master' into fix/providers
derrickmehaffy 7ac4fe5
PR Feedback
derrickmehaffy 04fa639
Merge branch 'master' into fix/providers
petersg83 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,8 +42,5 @@ | |
| "engines": { | ||
| "node": ">=12.x.x <=16.x.x", | ||
| "npm": ">=6.0.0" | ||
| }, | ||
| "strapi": { | ||
| "isProvider": true | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| root = true | ||
|
|
||
| [*] | ||
| indent_style = space | ||
| indent_size = 2 | ||
| end_of_line = lf | ||
| charset = utf-8 | ||
| trim_trailing_whitespace = true | ||
| insert_final_newline = true | ||
|
|
||
| [{package.json,*.yml}] | ||
| indent_style = space | ||
| indent_size = 2 | ||
|
|
||
| [*.md] | ||
| trim_trailing_whitespace = false | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| ############################ | ||
derrickmehaffy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # OS X | ||
| ############################ | ||
|
|
||
| .DS_Store | ||
| .AppleDouble | ||
| .LSOverride | ||
| Icon | ||
| .Spotlight-V100 | ||
| .Trashes | ||
| ._* | ||
|
|
||
|
|
||
| ############################ | ||
| # Linux | ||
| ############################ | ||
|
|
||
| *~ | ||
|
|
||
|
|
||
| ############################ | ||
| # Windows | ||
| ############################ | ||
|
|
||
| Thumbs.db | ||
| ehthumbs.db | ||
| Desktop.ini | ||
| $RECYCLE.BIN/ | ||
| *.cab | ||
| *.msi | ||
| *.msm | ||
| *.msp | ||
|
|
||
|
|
||
| ############################ | ||
| # Packages | ||
| ############################ | ||
|
|
||
| *.7z | ||
| *.csv | ||
| *.dat | ||
| *.dmg | ||
| *.gz | ||
| *.iso | ||
| *.jar | ||
| *.rar | ||
| *.tar | ||
| *.zip | ||
| *.com | ||
| *.class | ||
| *.dll | ||
| *.exe | ||
| *.o | ||
| *.seed | ||
| *.so | ||
| *.swo | ||
| *.swp | ||
| *.swn | ||
| *.swm | ||
| *.out | ||
| *.pid | ||
|
|
||
|
|
||
| ############################ | ||
| # Logs and databases | ||
| ############################ | ||
|
|
||
| .tmp | ||
| *.log | ||
| *.sql | ||
| *.sqlite | ||
|
|
||
|
|
||
| ############################ | ||
| # Misc. | ||
| ############################ | ||
|
|
||
| *# | ||
| .idea | ||
| nbproject | ||
|
|
||
|
|
||
| ############################ | ||
| # Node.js | ||
| ############################ | ||
|
|
||
| lib-cov | ||
| lcov.info | ||
| pids | ||
| logs | ||
| results | ||
| build | ||
| node_modules | ||
| .node_history | ||
| package-lock.json | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| ############################ | ||
| # OS X | ||
| ############################ | ||
|
|
||
| .DS_Store | ||
| .AppleDouble | ||
| .LSOverride | ||
| Icon | ||
| .Spotlight-V100 | ||
| .Trashes | ||
| ._* | ||
|
|
||
| ############################ | ||
| # Linux | ||
| ############################ | ||
|
|
||
| *~ | ||
|
|
||
| ############################ | ||
| # Windows | ||
| ############################ | ||
|
|
||
| Thumbs.db | ||
| ehthumbs.db | ||
| Desktop.ini | ||
| $RECYCLE.BIN/ | ||
| *.cab | ||
| *.msi | ||
| *.msm | ||
| *.msp | ||
|
|
||
| ############################ | ||
| # Packages | ||
| ############################ | ||
|
|
||
| *.7z | ||
| *.csv | ||
| *.dat | ||
| *.dmg | ||
| *.gz | ||
| *.iso | ||
| *.jar | ||
| *.rar | ||
| *.tar | ||
| *.zip | ||
| *.com | ||
| *.class | ||
| *.dll | ||
| *.exe | ||
| *.o | ||
| *.seed | ||
| *.so | ||
| *.swo | ||
| *.swp | ||
| *.swn | ||
| *.swm | ||
| *.out | ||
| *.pid | ||
|
|
||
| ############################ | ||
| # Logs and databases | ||
| ############################ | ||
|
|
||
| .tmp | ||
| *.log | ||
| *.sql | ||
| *.sqlite | ||
|
|
||
| ############################ | ||
| # Misc. | ||
| ############################ | ||
|
|
||
| *# | ||
| ssl | ||
| .editorconfig | ||
| .gitattributes | ||
| .idea | ||
| nbproject | ||
|
|
||
| ############################ | ||
| # Node.js | ||
| ############################ | ||
|
|
||
| lib-cov | ||
| lcov.info | ||
| pids | ||
| logs | ||
| results | ||
| build | ||
| node_modules | ||
| .node_history | ||
|
|
||
| ############################ | ||
| # Tests | ||
| ############################ | ||
|
|
||
| test | ||
| tests | ||
| __tests__ | ||
| jest.config.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,8 +55,5 @@ | |
| "engines": { | ||
| "node": ">=12.x.x <=16.x.x", | ||
| "npm": ">=6.0.0" | ||
| }, | ||
| "strapi": { | ||
| "isProvider": true | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,8 +42,5 @@ | |
| "engines": { | ||
| "node": ">=12.x.x <=16.x.x", | ||
| "npm": ">=6.0.0" | ||
| }, | ||
| "strapi": { | ||
| "isProvider": true | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an
.editorconfigfile at the root of the project, it isn't enough?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the other providers had it so I just mirrored the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll make a PR to remove them all I think and check if @alexandrebodin has an objection. You can let this file and I'll remove it in my PR