Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make component category translatable #12288

Merged
merged 2 commits into from Mar 11, 2022
Merged

Make component category translatable #12288

merged 2 commits into from Mar 11, 2022

Conversation

pr0gr8mm3r
Copy link
Contributor

What does it do?

Tries to use translation for category label in the dynamic zone component picker.

Why is it needed?

Internationalization of the admin panel.

How to test it?

Setup environment, create a dynamic zone with some components. Override the translation of the category name in src/admin/app.js (config.translations).

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #12288 (dc95212) into master (b037974) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12288   +/-   ##
=======================================
  Coverage   47.68%   47.68%           
=======================================
  Files         212      212           
  Lines        8223     8223           
  Branches     1863     1863           
=======================================
  Hits         3921     3921           
  Misses       3547     3547           
  Partials      755      755           
Flag Coverage Δ
front ?
unit 47.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b037974...dc95212. Read the comment docs.

@alexandrebodin alexandrebodin added pr: enhancement This PR adds or updates some part of the codebase or features source: core:content-type-builder Source is core/content-type-builder package source: core:content-manager Source is core/content-manager package and removed source: core:content-type-builder Source is core/content-type-builder package labels Mar 9, 2022
@soupette soupette added this to the 4.1.4 milestone Mar 11, 2022
@soupette soupette added this to In progress in Developer Experience - Old via automation Mar 11, 2022
@soupette soupette merged commit 463e9cc into strapi:master Mar 11, 2022
Developer Experience - Old automation moved this from In progress to Fixed/Shipped Mar 11, 2022
@pr0gr8mm3r pr0gr8mm3r deleted the patch-1 branch March 11, 2022 13:25
@maccomaccomaccomacco maccomaccomaccomacco moved this from Fixed/Shipped to Closed in Developer Experience - Old Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: core:content-manager Source is core/content-manager package
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants