-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Add configuration options to generate graphql schema + types #12467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12467 +/- ##
=======================================
Coverage 47.64% 47.64%
=======================================
Files 210 210
Lines 8177 8177
Branches 1849 1849
=======================================
Hits 3896 3896
Misses 3520 3520
Partials 761 761
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me :)
I put a suggestion for a line but feel free to ignore it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any tests you can add ?
b911c95 to
ae7731c
Compare
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/v4-graphql-type-definitions-are-not-generated/13470/11 |
What does it do?
Adds a
artifactsattribute in the GraphQL plugin configuration that allows generating artifacts (GraphQL schema & types definitions) for ou application.Also, add a
generateArtifactsconfig option to allow or not the generation of such artifacts. The default value istruein dev ENV andfalseotherwise.A documentation PR will follow soon.
Why is it needed?
In V3 it was possible to extract our GraphQL schema.
How to test it?
src/config/plugins.jsRelated issue(s)/PR(s)
Fix #12420