Skip to content

Conversation

@Bassel17
Copy link
Member

What does it do?

  • Fixes Strapi commands so they can work in a typescript project
  • Make users able to create a Typescript strapi project while creating a custom Strapi project
  • Make users able to create a Typescript plugin with the generate command

How to test it?

Related issue(s)/PR(s)

#13095
#13079

@strapi-cla
Copy link

strapi-cla commented Apr 26, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #13187 (c7b4d13) into features/typescript (4fa2804) will increase coverage by 48.23%.
The diff coverage is 85.71%.

@@                   Coverage Diff                    @@
##           features/typescript   #13187       +/-   ##
========================================================
+ Coverage                     0   48.23%   +48.23%     
========================================================
  Files                        0      245      +245     
  Lines                        0     8774     +8774     
  Branches                     0     1955     +1955     
========================================================
+ Hits                         0     4232     +4232     
- Misses                       0     3732     +3732     
- Partials                     0      810      +810     
Flag Coverage Δ
unit 48.23% <85.71%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/generators/generators/lib/plops/plugin.js 30.76% <0.00%> (ø)
packages/core/strapi/lib/commands/admin-create.js 87.23% <100.00%> (ø)
packages/core/strapi/lib/commands/admin-reset.js 100.00% <100.00%> (ø)
packages/core/utils/lib/pipe-async.js 100.00% <0.00%> (ø)
...8n/server/migrations/content-type/disable/index.js 86.66% <0.00%> (ø)
packages/generators/generators/lib/index.js 71.42% <0.00%> (ø)
...er/services/permission/sections-builder/section.js 100.00% <0.00%> (ø)
.../core/admin/server/controllers/formatters/index.js 100.00% <0.00%> (ø)
...lder/server/controllers/validation/model-schema.js 90.62% <0.00%> (ø)
...t-manager/server/policies/has-draft-and-publish.js 100.00% <0.00%> (ø)
... and 238 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa2804...c7b4d13. Read the comment docs.

@Bassel17 Bassel17 requested a review from Convly April 26, 2022 16:23
@Convly Convly merged commit 8c5bbef into features/typescript May 2, 2022
@Convly Convly deleted the typescript/fix-cli branch May 2, 2022 13:20
@strapi-bot
Copy link

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/strapi-v4-2-0-fourth-beta-for-typescript-support/18869/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants