-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Typescript add incremental compiling option before executing some CLI commands #13245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## features/typescript #13245 +/- ##
=======================================================
- Coverage 48.23% 48.20% -0.04%
=======================================================
Files 245 251 +6
Lines 8774 8954 +180
Branches 1955 2008 +53
=======================================================
+ Hits 4232 4316 +84
- Misses 3732 3820 +88
- Partials 810 818 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, some suggestions
| module.exports = { | ||
| /** | ||
| * Default TS -> JS Compilation for Strapi | ||
| * @param {string} tsConfigPath |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the jsdoc here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
By the way, did you take the opportunity to check the differences in compilation time with and without the incremental option? Both for the first build & for builds following a small change
|
@Bassel17 could you update your branch with features/typescript before we can merge? It should fix the front unit tests failing |
|
This codecov/project seems to be failing now, which is for tests coverage, what shall we do with that ? @Convly |
That's fine for this one, no need to worry about it. Thanks for the update! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/strapi-v4-2-0-fourth-beta-for-typescript-support/18869/1 |
What does it do?
compiler.run(configPath, configOptions);function to accept new options from the arguments.strapi console,strapi config:dump,strapi config:restore,strapi admin:create,strapi admin:resetWhy is it needed?
Allow the users to be able to execute CLI commands and succeed just like in a javascript Strapi project
How to test it?
Run the mentioned CLI commands in a Typescript Strapi project, they should behave in the same manner as a javascript strapi project.
docs can be found here: https://docs.strapi.io/developer-docs/latest/developer-resources/cli/CLI.html#strapi-configuration-dump