Skip to content

Conversation

@Bassel17
Copy link
Member

What does it do?

Fix the Factories Typings

Why is it needed?

To provide a good, and correct linting experience when using createCoreController or createCoreService or createCoreRouter

How to test it?

Try to add or wrap services or controllers or routes, it should work as explained in the docs:
https://docs.strapi.io/developer-docs/latest/development/backend-customization/routes.html#implementation
https://docs.strapi.io/developer-docs/latest/development/backend-customization/controllers.html#implementation
https://docs.strapi.io/developer-docs/latest/development/backend-customization/services.html

Related issue(s)/PR(s)

#13241

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #13289 (ad7c25c) into features/typescript (40dede5) will not change coverage.
The diff coverage is 44.44%.

@@                 Coverage Diff                  @@
##           features/typescript   #13289   +/-   ##
====================================================
  Coverage                48.20%   48.20%           
====================================================
  Files                      251      251           
  Lines                     8954     8954           
  Branches                  2008     2008           
====================================================
  Hits                      4316     4316           
  Misses                    3820     3820           
  Partials                   818      818           
Flag Coverage Δ
front ?
unit 48.20% <44.44%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/typescript/lib/compilers/basic.js 33.33% <33.33%> (ø)
packages/core/strapi/lib/commands/admin-create.js 85.71% <50.00%> (ø)
packages/core/strapi/lib/commands/admin-reset.js 96.29% <50.00%> (ø)
packages/utils/typescript/lib/compile.js 42.85% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a41040f...ad7c25c. Read the comment docs.

Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion

@Bassel17 Bassel17 requested a review from Convly May 17, 2022 09:38
@Bassel17 Bassel17 merged commit d727374 into features/typescript May 18, 2022
@Bassel17 Bassel17 deleted the typescript/factories-typing branch May 18, 2022 07:34
@strapi-bot
Copy link

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/strapi-v4-2-0-fourth-beta-for-typescript-support/18869/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants