-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Fix Factories typings #13289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Factories typings #13289
Conversation
Codecov Report
@@ Coverage Diff @@
## features/typescript #13289 +/- ##
====================================================
Coverage 48.20% 48.20%
====================================================
Files 251 251
Lines 8954 8954
Branches 2008 2008
====================================================
Hits 4316 4316
Misses 3820 3820
Partials 818 818
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/strapi-v4-2-0-fourth-beta-for-typescript-support/18869/1 |
What does it do?
Fix the Factories Typings
Why is it needed?
To provide a good, and correct linting experience when using
createCoreControllerorcreateCoreServiceorcreateCoreRouterHow to test it?
Try to add or wrap services or controllers or routes, it should work as explained in the docs:
https://docs.strapi.io/developer-docs/latest/development/backend-customization/routes.html#implementation
https://docs.strapi.io/developer-docs/latest/development/backend-customization/controllers.html#implementation
https://docs.strapi.io/developer-docs/latest/development/backend-customization/services.html
Related issue(s)/PR(s)
#13241