Fix admin user registration #13307
Merged
Fix admin user registration #13307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convly
added
source: core:admin
Codecov Report
@@ Coverage Diff @@
## master #13307 +/- ##
=======================================
Coverage 47.91% 47.92%
=======================================
Files 239 239
Lines 8813 8814 +1
Branches 1984 1984
=======================================
+ Hits 4223 4224 +1
Misses 3783 3783
Partials 807 807
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
alexandrebodin
previously approved these changes
May 13, 2022
alexandrebodin
approved these changes
May 13, 2022
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/user-creation-registration-token-not-being-generated/19079/4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Bypass the default admin user sanitation to force the
registrationTokenproperty to be included in the response payload of the create user controller.Why is it needed?
Since v4.1.10, we're removing the
registrationTokenfrom the admin API responses. Even if it works for almost every scenario, we still need this property in the admin user creation flow.How to test it?
Related issue(s)/PR(s)
fix #13300