Ml folder/transactions #13350
Merged
Ml folder/transactions #13350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersg83
force-pushed
the
ML-folder/transactions
branch
3 times, most recently
from
5815c3a to
ff380f9
Compare
Codecov Report
@@ Coverage Diff @@
## features/ML-folder #13350 +/- ##
======================================================
- Coverage 47.80% 47.64% -0.16%
======================================================
Files 234 234
Lines 8717 8746 +29
Branches 1947 1951 +4
======================================================
Hits 4167 4167
- Misses 3745 3771 +26
- Partials 805 808 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petersg83
force-pushed
the
ML-folder/transactions
branch
from
ff380f9 to
71f43f0
Compare
alexandrebodin
requested changes
May 24, 2022
| const existingFolders = await strapi.db | ||
| .queryBuilder(FOLDER_MODEL_UID) | ||
| .select(['id', 'uid', 'path']) | ||
| .where({ id: { $in: folderIds } }) |
There was a problem hiding this comment.
Note: if you do id: folderIds the $in will be implicit :)
There was a problem hiding this comment.
nice, good to know thanks :)
alexandrebodin
approved these changes
May 31, 2022
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.