Skip to content

Conversation

@Convly
Copy link
Member

@Convly Convly commented May 23, 2022

What does it do?

Adds incremental builds by default for the generated tsconfig.json files.

Why is it needed?

Increase builds time and decreases used resources

How to test it?

  1. Create a new TS project
  2. Check that the incremental option is enabled in the generated tsconfig.json file
  3. Make the first compilation, change a small line of code somewhere, and then rebuild. The second build should be faster than the first.

@Convly Convly added source: core:utils Source is core/utils or utils packages pr: enhancement This PR adds or updates some part of the codebase or features labels May 23, 2022
@Convly Convly added this to the 4.2.0 milestone May 23, 2022
@Convly Convly requested review from Bassel17 and alexandrebodin May 23, 2022 14:58
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #13378 (f95b022) into features/typescript (39c7f85) will not change coverage.
The diff coverage is n/a.

❗ Current head f95b022 differs from pull request most recent head eb012fa. Consider uploading reports for the commit eb012fa to get more accurate results

@@                 Coverage Diff                  @@
##           features/typescript   #13378   +/-   ##
====================================================
  Coverage                48.24%   48.24%           
====================================================
  Files                      252      252           
  Lines                     8963     8963           
  Branches                  2016     2016           
====================================================
  Hits                      4324     4324           
  Misses                    3821     3821           
  Partials                   818      818           
Flag Coverage Δ
front ∅ <ø> (∅)
unit 48.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a10ab...eb012fa. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very complex PR 🤔

Copy link
Member

@Bassel17 Bassel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Convly Convly merged commit d5111b9 into features/typescript May 23, 2022
@Convly Convly deleted the typescript/incremental-builds branch May 23, 2022 18:13
@Convly Convly removed this from the 4.2.0 milestone May 24, 2022
@strapi-bot
Copy link

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/strapi-v4-2-0-fourth-beta-for-typescript-support/18869/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: enhancement This PR adds or updates some part of the codebase or features source: core:utils Source is core/utils or utils packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants