-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[TS] Add generic typings for schemas #13416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
it seems we also have some unit tests failing but it doesn't seem to be related to this PR, the same tests are failing on features/typescript |
Codecov Report
@@ Coverage Diff @@
## features/typescript #13416 +/- ##
=======================================================
+ Coverage 48.83% 54.23% +5.40%
=======================================================
Files 259 1217 +958
Lines 9115 30804 +21689
Branches 2036 5597 +3561
=======================================================
+ Hits 4451 16706 +12255
- Misses 3839 12261 +8422
- Partials 825 1837 +1012
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…alues into an union type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job it starting to take form 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/strapi-second-beta-release-for-v-4-3-0/20170/1 |
What does it do?
Add generic typings for schemas and attributes.
Why is it needed?
This is the first step to adding more and more typings to the core Strapi elements.
The topic mentioned above is no longer true as the 4.7 parts of the code have been moved to another PR that will be merged later once TS 4.7 will be more available in the ecosystem