Skip to content

Conversation

@mithenks
Copy link

@mithenks mithenks commented Jun 6, 2022

What does it do?

Fix error in count when a query has joins.

Why is it needed?

The count value is used in pagination information.

Related issue(s)/PR(s)

Related to #7631, #13136 and #13443

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #13480 (c097d3a) into master (164ca83) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #13480      +/-   ##
==========================================
- Coverage   53.65%   53.64%   -0.01%     
==========================================
  Files        1171     1171              
  Lines       30073    30077       +4     
  Branches     5495     5498       +3     
==========================================
  Hits        16136    16136              
- Misses      12123    12125       +2     
- Partials     1814     1816       +2     
Flag Coverage Δ
front 55.91% <ø> (ø)
unit 48.23% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core/database/lib/query/query-builder.js 2.07% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 164ca83...c097d3a. Read the comment docs.

@strapi-bot
Copy link

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/incorrect-total-in-meta-pagination-when-filtering/16406/6

@Convly Convly self-assigned this Jun 20, 2022
@Convly Convly added source: core:database Source is core/database package pr: fix This PR is fixing a bug labels Jun 20, 2022
@Convly Convly added this to the 4.2.1 milestone Jun 20, 2022
@Convly Convly modified the milestones: 4.2.1, 4.2.2, 4.2.3 Jun 29, 2022
@alexandrebodin alexandrebodin modified the milestones: 4.2.3, 4.2.4 Jul 13, 2022
@gu-stav gu-stav modified the milestones: 4.2.4, 4.3.0 Jul 20, 2022
@Convly Convly modified the milestones: 4.3.0, 4.3.1 Jul 27, 2022
@petersg83 petersg83 modified the milestones: 4.3.1, 4.3.2 Aug 1, 2022
@alexandrebodin alexandrebodin modified the milestones: 4.3.2, 4.3.3 Aug 1, 2022
@alexandrebodin alexandrebodin removed this from the 4.3.3 milestone Aug 10, 2022
@alexandrebodin
Copy link
Member

hi @mithenks We cannot review this change as the code has changed in the meantime and it is conflicting. Can you update it ?

@alexandrebodin
Copy link
Member

alexandrebodin commented Mar 22, 2023

Hi, closing this for inactivity. We need to fix this more deeply :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix This PR is fixing a bug source: core:database Source is core/database package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants