-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[Features] Breadcrumbs Folders navigation #13917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13917 +/- ##
==========================================
+ Coverage 55.26% 55.38% +0.11%
==========================================
Files 1253 1259 +6
Lines 31593 31684 +91
Branches 5706 5732 +26
==========================================
+ Hits 17460 17547 +87
- Misses 12319 12323 +4
Partials 1814 1814
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
[Breadcrumbs] CM / ML Modal
…es/folder-breadcrumbs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redirections tested on both Media Library section and Upload modal, on 10 nested levels of folders, using Getstarted : OK to me (to go to nested folder and to root).
Breadcrumbs display tested on Upload modal using Getstarted on 10 levels of nested folders ; OK.

Breadcrumbs display tested on Chrome using Getstarted on 10 levels of nested folders : OK.

Design QA done by @maevalienard : OK too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few minor comments: nothing major. I've tested it and think it works very well. Good job on that.
What I am not happy with is the initial view of the media library and the modal: I find "Media Library" repetitive in the ML and it makes the modal very noisy. Similar to the back button: what do you think about hiding the breadcrumbs, if currentFolder === null?
/cc @maevalienard
packages/core/upload/admin/src/components/AssetDialog/BrowseStep/index.js
Outdated
Show resolved
Hide resolved
|
@gu-stav That would work to me, I didn't know it was technically feasible |
…es/folder-breadcrumbs
|
@gu-stav @maevalienard @MarionLemaire |
…es/folder-breadcrumbs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Gestarted using Chrome :
For Media Libary section : when on root, breadcrumb is not displayed. As soon as you get to a nested folder, breadcrumb appears. Redirections are still OK. Tested on 10 levels of nesting.
Same thing for Upload modal.
Ready to release !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's get it on the road! 🚢
Btw: thanks for getting rid of the title truncation. That's a big win!
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/media-library-folders-beta-is-live/19515/22 |


What
Breadcrumbs feature for Media Library folders & MediaLibraryInput modals
How to test it
Navigate into nested folders in the Media Library
Use Breadcrumbs to navigate into previous folders
Snapshot