Skip to content

Conversation

@gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Sep 13, 2022

What does it do?

This summary moves relational fields from the sidebar into the main view of the content-manager. Fields can now be resized as any other field, which should give content-editors more a better editing experience.

It improves the overall performance for applications with a large number of relations, because now the connected entities are lazily loaded instead of being part of the initial (internal) content API response.

Screenshots

81cfa797c9348eca7698588e63949273

3789f6e659894f39b286ee10ddd14a64

86e872343d8de032afed480b6026113f

Why is it needed?

Before relations were quite limited in space and we had numerous issues about loading performance.

How to test it?

This PR will be released as an alpha version. Details will follow.

Related issue(s)/PR(s)

@gu-stav gu-stav added source: core:content-manager Source is core/content-manager package pr: feature This PR adds a new feature labels Sep 13, 2022
@gu-stav gu-stav changed the title 🚀 Move relations into the content-manager main-view and improve loading performance Move relations into the content-manager main-view and improve loading performance Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 58.79% // Head: 58.72% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (e0901fe) compared to base (788ea22).
Patch coverage: 71.39% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14401      +/-   ##
==========================================
- Coverage   58.79%   58.72%   -0.07%     
==========================================
  Files        1327     1340      +13     
  Lines       32114    32500     +386     
  Branches     6007     6143     +136     
==========================================
+ Hits        18881    19086     +205     
- Misses      11371    11525     +154     
- Partials     1862     1889      +27     
Flag Coverage Δ
front 63.20% <81.84%> (+0.74%) ⬆️
unit 48.82% <20.00%> (-1.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...manager/components/DynamicTable/TableRows/index.js 37.03% <ø> (ø)
...c/content-manager/components/DynamicTable/index.js 43.58% <ø> (ø)
...manager/components/NonRepeatableComponent/index.js 41.37% <ø> (ø)
...mponents/RelationInputDataManager/utils/connect.js 100.00% <ø> (ø)
...omponents/RepeatableComponent/DraggedItem/index.js 25.92% <ø> (ø)
...nt-manager/components/RepeatableComponent/index.js 36.11% <0.00%> (ø)
...min/admin/src/content-manager/pages/App/reducer.js 95.83% <ø> (ø)
.../content-manager/pages/EditSettingsView/reducer.js 95.95% <ø> (-0.54%) ⬇️
...ntent-manager/pages/EditView/Header/utils/index.js 100.00% <ø> (ø)
...tent-manager/pages/EditView/Header/utils/select.js 40.00% <ø> (ø)
... and 87 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@petersg83 petersg83 added the flag: don't merge This PR should not be merged at the moment label Sep 16, 2022
@gu-stav gu-stav removed the flag: don't merge This PR should not be merged at the moment label Nov 3, 2022
@gu-stav
Copy link
Contributor Author

gu-stav commented Nov 3, 2022

@pwizla @meganelacheny Quick heads up: we are going to merge this PR into main today and it will be released as part of 4.5.0 next Wednesday (9th of November).

Copy link
Contributor

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gu-stav gu-stav merged commit dbefddc into main Nov 3, 2022
@gu-stav gu-stav deleted the feature/relations-main-view branch November 3, 2022 12:19
@pwizla
Copy link
Contributor

pwizla commented Nov 3, 2022

Thanks for the heads-up @gu-stav. I'll have a look at it Monday to make sure screenshots and everything (already published on docs-next) are up-to-date. 🙌

@gu-stav
Copy link
Contributor Author

gu-stav commented Nov 15, 2022

@strapi-bot
Copy link

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/required-relation-field/624/25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: feature This PR adds a new feature source: core:content-manager Source is core/content-manager package

Projects

None yet