useAPIErrorHandler: Reverse error handling (API -> Axios) #16162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +89 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #16162 +/- ##
==========================================
+ Coverage 59.95% 66.25% +6.29%
==========================================
Files 1485 1103 -382
Lines 37419 22654 -14765
Branches 7518 4183 -3335
==========================================
- Hits 22435 15009 -7426
+ Misses 12780 6757 -6023
+ Partials 2204 888 -1316
Flags with carried forward coverage won't be shown. Click here to find out more. see 382 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
joshuaellis
approved these changes
Mar 21, 2023
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/displaying-custom-error-message-in-admin-ui-in-strapi-4-8-x/27644/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Reverses the
AxiosErrorhandling ofuseFormatAPIError. Instead of normalizingAxiosErrorbefore the response error, it should work the other way around.Why is it needed?
I made a conceptual mistake in #16090. Axios always throws an
AxiosErrorregardless if the error origin is the network or an HTTP response code. Therefore we have to check first, whether the API returned an error (e.g.ValidationError), and only if this error can not be normalized, we should try and normalize the AxiosError.The error response is always more specific and should therefore have more priority.
Related issue(s)/PR(s)