New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove history & clean up some U&P tests #16992
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaellis
added
source: plugin:users-permissions
Source is plugin/users-permissions package
pr: chore
This PR contains chore tasks (cleanups, configs, tooling...)
labels
Jun 12, 2023
Size Change: -560 B (0%) Total Size: 1.52 MB
鈩癸笍 View Unchanged
|
joshuaellis
force-pushed
the
chore/remove-history-from-tests-pt1
branch
from
June 19, 2023 07:31
5ff32e8
to
707c4f0
Compare
gu-stav
reviewed
Jun 19, 2023
packages/plugins/users-permissions/admin/src/pages/Roles/CreatePage.js
Outdated
Show resolved
Hide resolved
gu-stav
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice cleanup!
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/new-content-type-fields-for-users-permissions-user-arent-preserved/29604/4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: chore
This PR contains chore tasks (cleanups, configs, tooling...)
source: plugin:users-permissions
Source is plugin/users-permissions package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
usePlugins
hook because it would cause an infinite loop in the test env - not great lucky it didn't happen in the app 馃檭history
in the test filesWhy is it needed?
Router
in our FE tests, we should MemoryRouter insteadNote
I think the pages could have had a lot more testing and there's a lot of code in the plugin in general that could be cleaned up and tested, but i'm waiting confirmation on the future of the plugin before sinking more time into it.
How to test it?
Related issue(s)/PR(s)