Chore: Refactor CM list-view review-workflow columns to use useEnterprise #17047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gu-stav
added
source: core:admin
gu-stav
changed the title
|
Size Change: -474 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
joshuaellis
reviewed
Jun 22, 2023
Comment on lines
+60
to
+61
| Similar to react-query this boolean flag allows disabling the EE import, e.g. when more than one condition needs to be applied. If `enabled` | ||
| is set to false, the first argument (CE_DATA) will be returned. |
There was a problem hiding this comment.
would a good example of this be where the EE addition is unique to a feature being enabled as opposed to EE in general?
joshuaellis
previously approved these changes
Jun 22, 2023
gu-stav
force-pushed
the
chore/rw-ee_else_ce
branch
from
2271a85 to
19d827b
Compare
markkaylor
reviewed
Jul 5, 2023
gu-stav
force-pushed
the
chore/rw-ee_else_ce
branch
from
8170af1 to
009f770
Compare
markkaylor
reviewed
Jul 6, 2023
Comment on lines
+104
to
+107
| if (!ReviewWorkflowsStage) { | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
This won't block rednering on content-types that don't have review workflows enabled 🤔? Maybe also check hasReviewWorkflows?
There was a problem hiding this comment.
In CE the component will be defined (so this condition won't match), but in EE ReviewWorkflowsStage can be null until the component has been loaded. We could handle this using a loading state, but in this instance I think it is better not to.
packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js
Show resolved
Hide resolved
joshuaellis
reviewed
Jul 6, 2023
packages/core/admin/admin/src/content-manager/pages/ListView/components/TableRows/index.js
Show resolved
Hide resolved
joshuaellis
approved these changes
Jul 6, 2023
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
useEnterprisehook with a boolean flagenableduseEnterpriseWhy is it needed?
ee_else_ceimport downwindow.strapi.isEEinvolved to avoid over-fetchingHow to test it?
Use Strapi in EE mode and navigate to a content-type in the CM list-view that has review-workflows enabled.