-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
chore: remove step from time configure view modal #17155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I need to update the User documentation, do you think this needs a migration to remove the step metadata from the attributes? Is there any BE bits I might have missed @Marc-Roig // @alexandrebodin |
|
Size Change: -220 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
I don't think that's worth it they should (to be verified during review) be removed after the next edition of the field. Added to my review list ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me. Nice cleanup!
|
Change look good to me, and I don't think we need a migration either. Did we consider plugins using the DatePicker when doing the refactor? There are some plugins using it |
Their values will still be valid 👍🏼 |
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/decrease-the-time-granularity-on-datetime-picker/19769/5 |
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/decrease-the-time-granularity-on-datetime-picker/19769/6 |
|
Now all "Configure the view" for the content type will error upon save. The response in the inspector: {
"data": null,
"error": {
"status": 400,
"name": "BadRequestError",
"message": "Bad Request",
"details": {
"name": "validationError",
"errors": [
"metadatas.post_date.edit field has unspecified keys: step"
]
}
}
} |
Experiencing the same problem here |
|
Unfortunately, I also still have the same errors on my end & start date field in strapi version |
|
I'm also having this issue ( |
|
I also waited for an update by strapi, but they don't fix it. They removed the step option for their date picker (selecting the time in 5 / 10 / 15 etc. minutes steps) and this is why the view isn't editable anymore if you had the steps defined before. I finally fixed that manually, by going into the Postgres database and searching for the general settings strapi table and removing the step attribute in the json. |
Thank you so much for responding. I've been looking all day for some direction to take to fix this. I didn't know where to start looking in postgres so this is a big help already. I will give these steps a try. |
|
I also fixed it by entering the database and manually removing the keys from the settings table. @grant-nadine. A general direction on how to fix this would be a database migration, I think? |
Sure, you need to find the table 'strapi_core_store_settings' and then search for the key 'plugin_content_manager_configuration_content_types::api::{{YOUR_DOCUMENT_TYPE}}' (look at the placeholder at the end) and edit the JSON by removing the "step" attribute from the datepickers. After that it should work. |
|
Thank you @bendixcrse and @SvenWesterlaken! Really appreciate you providing this info, huge help :) I wrote a migration and this has fixed the issue! |
What does it do?
Why is it needed?
Related issue(s)/PR(s)