Skip to content

Conversation

@joshuaellis
Copy link
Contributor

What does it do?

  • Removes the ability to set step with time fields in admin UI
  • Removes checking for metadata.step because it was only used for time, instead we set defaults based on attribute.type
  • Removes step check from metadatas schema

Why is it needed?

  • Since we released the ability to type a time in the TimePicker theres no need for a step & performance degrades when there are 1000s of items in the dropdown

Related issue(s)/PR(s)

  • resolves CONTENT-1530

@joshuaellis joshuaellis added source: core:content-manager Source is core/content-manager package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) flag: documentation This PR requires a documentation update labels Jun 30, 2023
@joshuaellis joshuaellis self-assigned this Jun 30, 2023
@joshuaellis
Copy link
Contributor Author

I need to update the User documentation, do you think this needs a migration to remove the step metadata from the attributes? Is there any BE bits I might have missed @Marc-Roig // @alexandrebodin

@github-actions
Copy link
Contributor

Size Change: -220 B (0%)

Total Size: 1.52 MB

Filename Size Change
packages/core/admin/build/content-manager.********.chunk.js 63 kB -205 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/core/admin/build/Admin_homePage.********.chunk.js 8.46 kB 0 B
packages/core/admin/build/Admin_InternalErrorPage.********.chunk.js 495 B 0 B
packages/core/admin/build/Admin_marketplace.********.chunk.js 8.34 kB 0 B
packages/core/admin/build/Admin_pluginsPage.********.chunk.js 1.18 kB 0 B
packages/core/admin/build/Admin_profilePage.********.chunk.js 3.43 kB 0 B
packages/core/admin/build/Admin_settingsPage.********.chunk.js 9.2 kB 0 B
packages/core/admin/build/admin-app.********.chunk.js 21.7 kB 0 B
packages/core/admin/build/Admin-authenticatedApp.********.chunk.js 8.27 kB 0 B
packages/core/admin/build/admin-edit-roles-page.********.chunk.js 15.8 kB 0 B
packages/core/admin/build/admin-edit-users.********.chunk.js 4.13 kB 0 B
packages/core/admin/build/admin-roles-list.********.chunk.js 3.06 kB 0 B
packages/core/admin/build/admin-users.********.chunk.js 6.17 kB 0 B
packages/core/admin/build/api-tokens-create-page.********.chunk.js 258 B 0 B
packages/core/admin/build/api-tokens-edit-page.********.chunk.js 258 B 0 B
packages/core/admin/build/api-tokens-list-page.********.chunk.js 2.86 kB 0 B
packages/core/admin/build/ar-json.********.chunk.js 19.6 kB 0 B
packages/core/admin/build/audit-logs-settings-page.********.chunk.js 4.1 kB 0 B
packages/core/admin/build/bb3108f7fd1e6179bde1.svg 352 B 0 B
packages/core/admin/build/bb4d0d527bdfb161bc5a.svg 2.33 kB 0 B
packages/core/admin/build/ca-json.********.chunk.js 12.9 kB 0 B
packages/core/admin/build/content-type-builder-list-view.********.chunk.js 7.15 kB 0 B
packages/core/admin/build/content-type-builder-translation-ar-json.********.chunk.js 1.35 kB 0 B
packages/core/admin/build/content-type-builder-translation-cs-json.********.chunk.js 2.88 kB 0 B
packages/core/admin/build/content-type-builder-translation-de-json.********.chunk.js 4.19 kB 0 B
packages/core/admin/build/content-type-builder-translation-dk-json.********.chunk.js 3.75 kB 0 B
packages/core/admin/build/content-type-builder-translation-en-json.********.chunk.js 4.2 kB 0 B
packages/core/admin/build/content-type-builder-translation-es-json.********.chunk.js 3.97 kB 0 B
packages/core/admin/build/content-type-builder-translation-fr-json.********.chunk.js 1.66 kB 0 B
packages/core/admin/build/content-type-builder-translation-id-json.********.chunk.js 3.34 kB 0 B
packages/core/admin/build/content-type-builder-translation-it-json.********.chunk.js 3.47 kB 0 B
packages/core/admin/build/content-type-builder-translation-ja-json.********.chunk.js 1.23 kB 0 B
packages/core/admin/build/content-type-builder-translation-ko-json.********.chunk.js 4.37 kB 0 B
packages/core/admin/build/content-type-builder-translation-ms-json.********.chunk.js 3.28 kB 0 B
packages/core/admin/build/content-type-builder-translation-nl-json.********.chunk.js 3.3 kB 0 B
packages/core/admin/build/content-type-builder-translation-pl-json.********.chunk.js 4.16 kB 0 B
packages/core/admin/build/content-type-builder-translation-pt-BR-json.********.chunk.js 4.17 kB 0 B
packages/core/admin/build/content-type-builder-translation-pt-json.********.chunk.js 1.1 kB 0 B
packages/core/admin/build/content-type-builder-translation-ru-json.********.chunk.js 4.69 kB 0 B
packages/core/admin/build/content-type-builder-translation-sk-json.********.chunk.js 3.74 kB 0 B
packages/core/admin/build/content-type-builder-translation-sv-json.********.chunk.js 4.18 kB 0 B
packages/core/admin/build/content-type-builder-translation-th-json.********.chunk.js 4.36 kB 0 B
packages/core/admin/build/content-type-builder-translation-tr-json.********.chunk.js 3.84 kB 0 B
packages/core/admin/build/content-type-builder-translation-uk-json.********.chunk.js 4.37 kB 0 B
packages/core/admin/build/content-type-builder-translation-zh-Hans-json.********.chunk.js 3.5 kB 0 B
packages/core/admin/build/content-type-builder-translation-zh-json.********.chunk.js 4.5 kB 0 B
packages/core/admin/build/content-type-builder.********.chunk.js 31.1 kB 0 B
packages/core/admin/build/cs-json.********.chunk.js 5.88 kB 0 B
packages/core/admin/build/de-json.********.chunk.js 12.8 kB 0 B
packages/core/admin/build/dk-json.********.chunk.js 10.5 kB 0 B
packages/core/admin/build/email-settings-page.********.chunk.js 3.6 kB 0 B
packages/core/admin/build/email-translation-ar-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-cs-json.********.chunk.js 121 B 0 B
packages/core/admin/build/email-translation-de-json.********.chunk.js 120 B 0 B
packages/core/admin/build/email-translation-dk-json.********.chunk.js 616 B 0 B
packages/core/admin/build/email-translation-en-json.********.chunk.js 610 B 0 B
packages/core/admin/build/email-translation-es-json.********.chunk.js 675 B 0 B
packages/core/admin/build/email-translation-fr-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-id-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-it-json.********.chunk.js 118 B 0 B
packages/core/admin/build/email-translation-ja-json.********.chunk.js 787 B 0 B
packages/core/admin/build/email-translation-ko-json.********.chunk.js 758 B 0 B
packages/core/admin/build/email-translation-ms-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-nl-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-pl-json.********.chunk.js 660 B 0 B
packages/core/admin/build/email-translation-pt-BR-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-pt-json.********.chunk.js 668 B 0 B
packages/core/admin/build/email-translation-ru-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-sk-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-th-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-tr-json.********.chunk.js 687 B 0 B
packages/core/admin/build/email-translation-uk-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-vi-json.********.chunk.js 122 B 0 B
packages/core/admin/build/email-translation-zh-Hans-json.********.chunk.js 473 B 0 B
packages/core/admin/build/email-translation-zh-json.********.chunk.js 730 B 0 B
packages/core/admin/build/en-json.********.chunk.js 15.2 kB 0 B
packages/core/admin/build/es-json.********.chunk.js 14.1 kB 0 B
packages/core/admin/build/eu-json.********.chunk.js 14.1 kB 0 B
packages/core/admin/build/fr-json.********.chunk.js 12.6 kB 0 B
packages/core/admin/build/gu-json.********.chunk.js 14.2 kB 0 B
packages/core/admin/build/he-json.********.chunk.js 6.48 kB 0 B
packages/core/admin/build/hi-json.********.chunk.js 16.3 kB 0 B
packages/core/admin/build/highlight.js.********.chunk.js 842 B 0 B
packages/core/admin/build/hu-json.********.chunk.js 15.4 kB 0 B
packages/core/admin/build/i18n-settings-page.********.chunk.js 4.94 kB 0 B
packages/core/admin/build/i18n-translation-de-json.********.chunk.js 1.62 kB 0 B
packages/core/admin/build/i18n-translation-dk-json.********.chunk.js 1.62 kB 0 B
packages/core/admin/build/i18n-translation-en-json.********.chunk.js 1.57 kB 0 B
packages/core/admin/build/i18n-translation-es-json.********.chunk.js 1.68 kB 0 B
packages/core/admin/build/i18n-translation-fr-json.********.chunk.js 1.73 kB 0 B
packages/core/admin/build/i18n-translation-ko-json.********.chunk.js 1.86 kB 0 B
packages/core/admin/build/i18n-translation-pl-json.********.chunk.js 1.8 kB 0 B
packages/core/admin/build/i18n-translation-ru-json.********.chunk.js 2.3 kB 0 B
packages/core/admin/build/i18n-translation-tr-json.********.chunk.js 1.7 kB 0 B
packages/core/admin/build/i18n-translation-zh-Hans-json.********.chunk.js 1.64 kB 0 B
packages/core/admin/build/i18n-translation-zh-json.********.chunk.js 1.73 kB 0 B
packages/core/admin/build/id-json.********.chunk.js 7.46 kB 0 B
packages/core/admin/build/index.html 263 B 0 B
packages/core/admin/build/it-json.********.chunk.js 7.93 kB 0 B
packages/core/admin/build/ja-json.********.chunk.js 12.2 kB 0 B
packages/core/admin/build/ko-json.********.chunk.js 11.5 kB 0 B
packages/core/admin/build/main.********.js 587 kB -7 B (0%)
packages/core/admin/build/ml-json.********.chunk.js 17.2 kB 0 B
packages/core/admin/build/ms-json.********.chunk.js 6.16 kB 0 B
packages/core/admin/build/nl-json.********.chunk.js 14.3 kB 0 B
packages/core/admin/build/no-json.********.chunk.js 5.48 kB 0 B
packages/core/admin/build/pl-json.********.chunk.js 13.1 kB 0 B
packages/core/admin/build/pt-BR-json.********.chunk.js 13.8 kB 0 B
packages/core/admin/build/pt-json.********.chunk.js 5.71 kB 0 B
packages/core/admin/build/review-workflows-settings.********.chunk.js 7.07 kB 0 B
packages/core/admin/build/ru-json.********.chunk.js 21.6 kB 0 B
packages/core/admin/build/runtime~main.********.js 4.82 kB 0 B
packages/core/admin/build/sa-json.********.chunk.js 16.9 kB 0 B
packages/core/admin/build/sk-json.********.chunk.js 11.8 kB 0 B
packages/core/admin/build/sso-settings-page.********.chunk.js 1.75 kB 0 B
packages/core/admin/build/sv-json.********.chunk.js 14.1 kB 0 B
packages/core/admin/build/th-json.********.chunk.js 9.01 kB 0 B
packages/core/admin/build/tr-json.********.chunk.js 13.7 kB 0 B
packages/core/admin/build/transfer-tokens-create-page.********.chunk.js 262 B 0 B
packages/core/admin/build/transfer-tokens-edit-page.********.chunk.js 262 B 0 B
packages/core/admin/build/transfer-tokens-list-page.********.chunk.js 2.98 kB 0 B
packages/core/admin/build/uk-json.********.chunk.js 7.71 kB 0 B
packages/core/admin/build/Upload_ConfigureTheView.********.chunk.js 1.74 kB 0 B
packages/core/admin/build/upload-settings.********.chunk.js 3.08 kB 0 B
packages/core/admin/build/upload-translation-ca-json.********.chunk.js 2.48 kB 0 B
packages/core/admin/build/upload-translation-de-json.********.chunk.js 2.19 kB 0 B
packages/core/admin/build/upload-translation-dk-json.********.chunk.js 1.96 kB 0 B
packages/core/admin/build/upload-translation-en-json.********.chunk.js 2.58 kB 0 B
packages/core/admin/build/upload-translation-es-json.********.chunk.js 2.45 kB 0 B
packages/core/admin/build/upload-translation-fr-json.********.chunk.js 2.86 kB 0 B
packages/core/admin/build/upload-translation-he-json.********.chunk.js 1.84 kB 0 B
packages/core/admin/build/upload-translation-it-json.********.chunk.js 1.56 kB 0 B
packages/core/admin/build/upload-translation-ja-json.********.chunk.js 1.92 kB 0 B
packages/core/admin/build/upload-translation-ko-json.********.chunk.js 2.5 kB 0 B
packages/core/admin/build/upload-translation-ms-json.********.chunk.js 1.41 kB 0 B
packages/core/admin/build/upload-translation-pl-json.********.chunk.js 2.19 kB 0 B
packages/core/admin/build/upload-translation-pt-BR-json.********.chunk.js 1.61 kB 0 B
packages/core/admin/build/upload-translation-pt-json.********.chunk.js 1.61 kB 0 B
packages/core/admin/build/upload-translation-ru-json.********.chunk.js 2.02 kB 0 B
packages/core/admin/build/upload-translation-sk-json.********.chunk.js 2.58 kB 0 B
packages/core/admin/build/upload-translation-th-json.********.chunk.js 1.99 kB 0 B
packages/core/admin/build/upload-translation-tr-json.********.chunk.js 2.35 kB 0 B
packages/core/admin/build/upload-translation-uk-json.********.chunk.js 1.96 kB 0 B
packages/core/admin/build/upload-translation-zh-Hans-json.********.chunk.js 3.12 kB 0 B
packages/core/admin/build/upload-translation-zh-json.********.chunk.js 2.65 kB 0 B
packages/core/admin/build/upload.********.chunk.js 7.61 kB 0 B
packages/core/admin/build/users-advanced-settings-page.********.chunk.js 3.42 kB 0 B
packages/core/admin/build/users-email-settings-page.********.chunk.js 3.53 kB 0 B
packages/core/admin/build/users-permissions-translation-ar-json.********.chunk.js 1.51 kB 0 B
packages/core/admin/build/users-permissions-translation-cs-json.********.chunk.js 1.46 kB 0 B
packages/core/admin/build/users-permissions-translation-de-json.********.chunk.js 1.58 kB 0 B
packages/core/admin/build/users-permissions-translation-dk-json.********.chunk.js 1.92 kB 0 B
packages/core/admin/build/users-permissions-translation-en-json.********.chunk.js 1.81 kB 0 B
packages/core/admin/build/users-permissions-translation-es-json.********.chunk.js 2.05 kB 0 B
packages/core/admin/build/users-permissions-translation-fr-json.********.chunk.js 1.41 kB 0 B
packages/core/admin/build/users-permissions-translation-id-json.********.chunk.js 1.49 kB 0 B
packages/core/admin/build/users-permissions-translation-it-json.********.chunk.js 1.57 kB 0 B
packages/core/admin/build/users-permissions-translation-ja-json.********.chunk.js 1.53 kB 0 B
packages/core/admin/build/users-permissions-translation-ko-json.********.chunk.js 2.23 kB 0 B
packages/core/admin/build/users-permissions-translation-ms-json.********.chunk.js 1.27 kB 0 B
packages/core/admin/build/users-permissions-translation-nl-json.********.chunk.js 1.32 kB 0 B
packages/core/admin/build/users-permissions-translation-pl-json.********.chunk.js 2.11 kB 0 B
packages/core/admin/build/users-permissions-translation-pt-BR-json.********.chunk.js 1.21 kB 0 B
packages/core/admin/build/users-permissions-translation-pt-json.********.chunk.js 1.3 kB 0 B
packages/core/admin/build/users-permissions-translation-ru-json.********.chunk.js 2.75 kB 0 B
packages/core/admin/build/users-permissions-translation-sk-json.********.chunk.js 1.38 kB 0 B
packages/core/admin/build/users-permissions-translation-sv-json.********.chunk.js 2.01 kB 0 B
packages/core/admin/build/users-permissions-translation-th-json.********.chunk.js 2.01 kB 0 B
packages/core/admin/build/users-permissions-translation-tr-json.********.chunk.js 2.07 kB 0 B
packages/core/admin/build/users-permissions-translation-uk-json.********.chunk.js 1.75 kB 0 B
packages/core/admin/build/users-permissions-translation-vi-json.********.chunk.js 1.51 kB 0 B
packages/core/admin/build/users-permissions-translation-zh-Hans-json.********.chunk.js 2.19 kB 0 B
packages/core/admin/build/users-permissions-translation-zh-json.********.chunk.js 2.1 kB 0 B
packages/core/admin/build/users-providers-settings-page.********.chunk.js 5.52 kB 0 B
packages/core/admin/build/users-roles-settings-page.********.chunk.js 7.37 kB 0 B
packages/core/admin/build/vi-json.********.chunk.js 5.98 kB 0 B
packages/core/admin/build/webhook-edit-page.********.chunk.js 5.64 kB 0 B
packages/core/admin/build/webhook-list-page.********.chunk.js 3.14 kB 0 B
packages/core/admin/build/zh-Hans-json.********.chunk.js 17.2 kB 0 B
packages/core/admin/build/zh-json.********.chunk.js 15.1 kB 0 B
packages/core/helper-plugin/build/helper-plugin.esm.js 24.4 kB -4 B (0%)
packages/core/helper-plugin/build/helper-plugin.js 22.3 kB -4 B (0%)

compressed-size-action

@alexandrebodin
Copy link
Member

I need to update the User documentation, do you think this needs a migration to remove the step metadata from the attributes? Is there any BE bits I might have missed @Marc-Roig // @alexandrebodin

I don't think that's worth it they should (to be verified during review) be removed after the next edition of the field. Added to my review list ✅

@gu-stav gu-stav self-requested a review July 4, 2023 13:39
Copy link
Contributor

@gu-stav gu-stav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me. Nice cleanup!

@Marc-Roig
Copy link
Contributor

Marc-Roig commented Jul 5, 2023

Change look good to me, and I don't think we need a migration either.

Did we consider plugins using the DatePicker when doing the refactor? There are some plugins using it
https://github.com/ComfortablyCoding/strapi-plugin-publisher/blob/963d516b5aed0c724529ab1ba79b4ba9b6875955/server/config/index.js#L18
https://github.com/webbio/strapi-plugin-scheduler/blob/4d162483fd30ee1ffdeee631fd31e0e45aa0abfd/admin/src/components/Scheduler/index.tsx#L188

@joshuaellis
Copy link
Contributor Author

Change look good to me, and I don't think we need a migration either.

Did we consider plugins using the DatePicker when doing the refactor? There are some plugins using it ComfortablyCoding/strapi-plugin-publisher@963d516/server/config/index.js#L18 webbio/strapi-plugin-scheduler@4d16248/admin/src/components/Scheduler/index.tsx#L188

Their values will still be valid 👍🏼

@joshuaellis joshuaellis added this to the 4.11.5 milestone Jul 5, 2023
@joshuaellis joshuaellis merged commit d2d5476 into main Jul 5, 2023
@joshuaellis joshuaellis deleted the chore/remove-step-from-time branch July 5, 2023 15:54
@strapi-bot
Copy link

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/decrease-the-time-granularity-on-datetime-picker/19769/5

@strapi-bot
Copy link

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/decrease-the-time-granularity-on-datetime-picker/19769/6

@Cerlancism
Copy link

step is still stored in strapi_core_store_settings for the "Configure the view" data if configured the time step previously.

Now all "Configure the view" for the content type will error upon save.

The response in the inspector:

{
	"data": null,
	"error": {
		"status": 400,
		"name": "BadRequestError",
		"message": "Bad Request",
		"details": {
			"name": "validationError",
			"errors": [
				"metadatas.post_date.edit field has unspecified keys: step"
			]
		}
	}
}

@DevChanQ
Copy link

DevChanQ commented Sep 7, 2023

step is still stored in strapi_core_store_settings for the "Configure the view" data if configured the time step previously.

Now all "Configure the view" for the content type will error upon save.

The response in the inspector:

{
	"data": null,
	"error": {
		"status": 400,
		"name": "BadRequestError",
		"message": "Bad Request",
		"details": {
			"name": "validationError",
			"errors": [
				"metadatas.post_date.edit field has unspecified keys: step"
			]
		}
	}
}

Experiencing the same problem here

@SvenWesterlaken
Copy link

Unfortunately, I also still have the same errors on my end & start date field in strapi version 4.16.2

@grant-nadine
Copy link

I'm also having this issue (field has unspecified keys: step" in reference to a dateTime field) with a rather large impact on my client - they can't set Editable field to False or configure the view. Is there any progress on this? Or a work around/fix that can be implemented in the meantime?

@bendixcrse
Copy link

bendixcrse commented Feb 27, 2024

I also waited for an update by strapi, but they don't fix it. They removed the step option for their date picker (selecting the time in 5 / 10 / 15 etc. minutes steps) and this is why the view isn't editable anymore if you had the steps defined before.

I finally fixed that manually, by going into the Postgres database and searching for the general settings strapi table and removing the step attribute in the json.

@grant-nadine
Copy link

I also waited for an update by strapi, but they don't fix it. They removed the step option for their date picker (selecting the time in 5 / 10 / 15 etc. minutes steps) and this is why the view isn't editable anymore if you had the steps defined before.

I finally fixed that manually, by going into the Postgres database and searching for the general settings strapi table and removing the step attribute in the json.

Thank you so much for responding. I've been looking all day for some direction to take to fix this. I didn't know where to start looking in postgres so this is a big help already. I will give these steps a try.

@SvenWesterlaken
Copy link

I also fixed it by entering the database and manually removing the keys from the settings table. @grant-nadine.

A general direction on how to fix this would be a database migration, I think?

@bendixcrse
Copy link

I also waited for an update by strapi, but they don't fix it. They removed the step option for their date picker (selecting the time in 5 / 10 / 15 etc. minutes steps) and this is why the view isn't editable anymore if you had the steps defined before.
I finally fixed that manually, by going into the Postgres database and searching for the general settings strapi table and removing the step attribute in the json.

Thank you so much for responding. I've been looking all day for some direction to take to fix this. I didn't know where to start looking in postgres so this is a big help already. I will give these steps a try.

Sure, you need to find the table 'strapi_core_store_settings' and then search for the key 'plugin_content_manager_configuration_content_types::api::{{YOUR_DOCUMENT_TYPE}}' (look at the placeholder at the end) and edit the JSON by removing the "step" attribute from the datepickers. After that it should work.

@grant-nadine
Copy link

grant-nadine commented Feb 27, 2024

Thank you @bendixcrse and @SvenWesterlaken! Really appreciate you providing this info, huge help :) I wrote a migration and this has fixed the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:content-manager Source is core/content-manager package

Projects

None yet

Development

Successfully merging this pull request may close these issues.