[TS][Entity-Service] Add type definition for the findOne method #17520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| files?: unknown; // TODO | ||
| }; | ||
|
|
||
| type SelectReadWrite<TContentTypeUID extends Common.UID.ContentType> = SelectRead<TContentTypeUID> & |
There was a problem hiding this comment.
Is this for a later implementation?
There was a problem hiding this comment.
Yep: create, update, etc..
innerdvations
approved these changes
Aug 1, 2023
|
[Waiting for #17519 to be merged, and then merging this one] |
christiancp100
approved these changes
Aug 1, 2023
…trapi into types/entity-services/find-one
Base automatically changed from
types/entity-services/base-type
to
features/types/entity-service
August 1, 2023 14:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?