fix: cannot clear date-field #17599

joshuaellis · 2023-08-08T07:13:41Z

What does it do?

When a date field is cleared we pass null as the onChange value, however we weren't checking this before trying to use formatISO, we now do this. It also fixes a rogue module.exports declaration we have in the codebase.

Why is it needed?

Users were unable to clear date fields

How to test it?

Go to entry with date field & date time field
clear the date
see no errors

Related issue(s)/PR(s)

resolves Cannot clear date field #16493
partially resolves CONTENT-1639

markkaylor

lgtm, I tested it locally.

packages/core/helper-plugin/src/components/GenericInput.jsx

github-actions · 2023-08-08T07:22:52Z

Size Change: -55 B (0%)

Total Size: 1.52 MB

Filename	Size	Change
`packages/core/admin/build/main.********.js`	581 kB	-63 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
`packages/core/admin/build/Admin_homePage.********.chunk.js`	8.43 kB	0 B
`packages/core/admin/build/Admin_InternalErrorPage.********.chunk.js`	494 B	0 B
`packages/core/admin/build/Admin_marketplace.********.chunk.js`	8.3 kB	0 B
`packages/core/admin/build/Admin_pluginsPage.********.chunk.js`	1.17 kB	0 B
`packages/core/admin/build/Admin_profilePage.********.chunk.js`	3.45 kB	0 B
`packages/core/admin/build/Admin_settingsPage.********.chunk.js`	9.07 kB	0 B
`packages/core/admin/build/admin-app.********.chunk.js`	19.4 kB	0 B
`packages/core/admin/build/Admin-authenticatedApp.********.chunk.js`	8.25 kB	0 B
`packages/core/admin/build/admin-edit-roles-page.********.chunk.js`	16.3 kB	0 B
`packages/core/admin/build/admin-edit-users.********.chunk.js`	4.02 kB	0 B
`packages/core/admin/build/admin-roles-list.********.chunk.js`	3.09 kB	0 B
`packages/core/admin/build/admin-users.********.chunk.js`	5.76 kB	0 B
`packages/core/admin/build/api-tokens-create-page.********.chunk.js`	258 B	0 B
`packages/core/admin/build/api-tokens-edit-page.********.chunk.js`	257 B	0 B
`packages/core/admin/build/api-tokens-list-page.********.chunk.js`	2.85 kB	0 B
`packages/core/admin/build/ar-json.********.chunk.js`	19.6 kB	0 B
`packages/core/admin/build/audit-logs-settings-page.********.chunk.js`	4.05 kB	0 B
`packages/core/admin/build/bb3108f7fd1e6179bde1.svg`	352 B	0 B
`packages/core/admin/build/bb4d0d527bdfb161bc5a.svg`	2.33 kB	0 B
`packages/core/admin/build/ca-json.********.chunk.js`	13 kB	0 B
`packages/core/admin/build/content-manager.********.chunk.js`	63.6 kB	0 B
`packages/core/admin/build/content-type-builder-list-view.********.chunk.js`	7.17 kB	0 B
`packages/core/admin/build/content-type-builder-translation-ar-json.********.chunk.js`	1.37 kB	0 B
`packages/core/admin/build/content-type-builder-translation-cs-json.********.chunk.js`	2.89 kB	0 B
`packages/core/admin/build/content-type-builder-translation-de-json.********.chunk.js`	4.21 kB	0 B
`packages/core/admin/build/content-type-builder-translation-dk-json.********.chunk.js`	3.76 kB	0 B
`packages/core/admin/build/content-type-builder-translation-en-json.********.chunk.js`	4.12 kB	0 B
`packages/core/admin/build/content-type-builder-translation-es-json.********.chunk.js`	3.98 kB	0 B
`packages/core/admin/build/content-type-builder-translation-fr-json.********.chunk.js`	1.68 kB	0 B
`packages/core/admin/build/content-type-builder-translation-id-json.********.chunk.js`	3.35 kB	0 B
`packages/core/admin/build/content-type-builder-translation-it-json.********.chunk.js`	3.48 kB	0 B
`packages/core/admin/build/content-type-builder-translation-ja-json.********.chunk.js`	1.23 kB	0 B
`packages/core/admin/build/content-type-builder-translation-ko-json.********.chunk.js`	4.38 kB	0 B
`packages/core/admin/build/content-type-builder-translation-ms-json.********.chunk.js`	3.29 kB	0 B
`packages/core/admin/build/content-type-builder-translation-nl-json.********.chunk.js`	3.31 kB	0 B
`packages/core/admin/build/content-type-builder-translation-pl-json.********.chunk.js`	4.17 kB	0 B
`packages/core/admin/build/content-type-builder-translation-pt-BR-json.********.chunk.js`	4.18 kB	0 B
`packages/core/admin/build/content-type-builder-translation-pt-json.********.chunk.js`	1.1 kB	0 B
`packages/core/admin/build/content-type-builder-translation-ru-json.********.chunk.js`	4.7 kB	0 B
`packages/core/admin/build/content-type-builder-translation-sk-json.********.chunk.js`	3.75 kB	0 B
`packages/core/admin/build/content-type-builder-translation-sv-json.********.chunk.js`	4.19 kB	0 B
`packages/core/admin/build/content-type-builder-translation-th-json.********.chunk.js`	4.37 kB	0 B
`packages/core/admin/build/content-type-builder-translation-tr-json.********.chunk.js`	3.85 kB	0 B
`packages/core/admin/build/content-type-builder-translation-uk-json.********.chunk.js`	4.38 kB	0 B
`packages/core/admin/build/content-type-builder-translation-zh-Hans-json.********.chunk.js`	3.51 kB	0 B
`packages/core/admin/build/content-type-builder-translation-zh-json.********.chunk.js`	4.51 kB	0 B
`packages/core/admin/build/content-type-builder.********.chunk.js`	30.9 kB	0 B
`packages/core/admin/build/cs-json.********.chunk.js`	5.88 kB	0 B
`packages/core/admin/build/de-json.********.chunk.js`	12.8 kB	0 B
`packages/core/admin/build/dk-json.********.chunk.js`	10.5 kB	0 B
`packages/core/admin/build/email-settings-page.********.chunk.js`	3.6 kB	0 B
`packages/core/admin/build/email-translation-ar-json.********.chunk.js`	122 B	0 B
`packages/core/admin/build/email-translation-cs-json.********.chunk.js`	121 B	0 B
`packages/core/admin/build/email-translation-de-json.********.chunk.js`	120 B	0 B
`packages/core/admin/build/email-translation-dk-json.********.chunk.js`	616 B	0 B
`packages/core/admin/build/email-translation-en-json.********.chunk.js`	610 B	0 B
`packages/core/admin/build/email-translation-es-json.********.chunk.js`	675 B	0 B
`packages/core/admin/build/email-translation-fr-json.********.chunk.js`	122 B	0 B
`packages/core/admin/build/email-translation-id-json.********.chunk.js`	122 B	0 B
`packages/core/admin/build/email-translation-it-json.********.chunk.js`	118 B	0 B
`packages/core/admin/build/email-translation-ja-json.********.chunk.js`	787 B	0 B
`packages/core/admin/build/email-translation-ko-json.********.chunk.js`	758 B	0 B
`packages/core/admin/build/email-translation-ms-json.********.chunk.js`	122 B	0 B
`packages/core/admin/build/email-translation-nl-json.********.chunk.js`	122 B	0 B
`packages/core/admin/build/email-translation-pl-json.********.chunk.js`	660 B	0 B
`packages/core/admin/build/email-translation-pt-BR-json.********.chunk.js`	122 B	0 B
`packages/core/admin/build/email-translation-pt-json.********.chunk.js`	668 B	0 B
`packages/core/admin/build/email-translation-ru-json.********.chunk.js`	122 B	0 B
`packages/core/admin/build/email-translation-sk-json.********.chunk.js`	122 B	0 B
`packages/core/admin/build/email-translation-th-json.********.chunk.js`	122 B	0 B
`packages/core/admin/build/email-translation-tr-json.********.chunk.js`	687 B	0 B
`packages/core/admin/build/email-translation-uk-json.********.chunk.js`	122 B	0 B
`packages/core/admin/build/email-translation-vi-json.********.chunk.js`	122 B	0 B
`packages/core/admin/build/email-translation-zh-Hans-json.********.chunk.js`	473 B	0 B
`packages/core/admin/build/email-translation-zh-json.********.chunk.js`	730 B	0 B
`packages/core/admin/build/en-json.********.chunk.js`	15.6 kB	0 B
`packages/core/admin/build/es-json.********.chunk.js`	14.2 kB	0 B
`packages/core/admin/build/eu-json.********.chunk.js`	14.2 kB	0 B
`packages/core/admin/build/fr-json.********.chunk.js`	12.6 kB	0 B
`packages/core/admin/build/gu-json.********.chunk.js`	14.2 kB	0 B
`packages/core/admin/build/he-json.********.chunk.js`	6.48 kB	0 B
`packages/core/admin/build/hi-json.********.chunk.js`	16.4 kB	0 B
`packages/core/admin/build/highlight.js.********.chunk.js`	842 B	0 B
`packages/core/admin/build/hu-json.********.chunk.js`	15.4 kB	0 B
`packages/core/admin/build/i18n-settings-page.********.chunk.js`	4.94 kB	0 B
`packages/core/admin/build/i18n-translation-de-json.********.chunk.js`	1.62 kB	0 B
`packages/core/admin/build/i18n-translation-dk-json.********.chunk.js`	1.62 kB	0 B
`packages/core/admin/build/i18n-translation-en-json.********.chunk.js`	1.57 kB	0 B
`packages/core/admin/build/i18n-translation-es-json.********.chunk.js`	1.68 kB	0 B
`packages/core/admin/build/i18n-translation-fr-json.********.chunk.js`	1.73 kB	0 B
`packages/core/admin/build/i18n-translation-ko-json.********.chunk.js`	1.86 kB	0 B
`packages/core/admin/build/i18n-translation-pl-json.********.chunk.js`	1.8 kB	0 B
`packages/core/admin/build/i18n-translation-ru-json.********.chunk.js`	2.3 kB	0 B
`packages/core/admin/build/i18n-translation-tr-json.********.chunk.js`	1.7 kB	0 B
`packages/core/admin/build/i18n-translation-zh-Hans-json.********.chunk.js`	1.64 kB	0 B
`packages/core/admin/build/i18n-translation-zh-json.********.chunk.js`	1.73 kB	0 B
`packages/core/admin/build/id-json.********.chunk.js`	7.46 kB	0 B
`packages/core/admin/build/index.html`	263 B	0 B
`packages/core/admin/build/it-json.********.chunk.js`	7.93 kB	0 B
`packages/core/admin/build/ja-json.********.chunk.js`	12.3 kB	0 B
`packages/core/admin/build/ko-json.********.chunk.js`	11.6 kB	0 B
`packages/core/admin/build/ml-json.********.chunk.js`	17.3 kB	0 B
`packages/core/admin/build/ms-json.********.chunk.js`	6.16 kB	0 B
`packages/core/admin/build/nl-json.********.chunk.js`	14.4 kB	0 B
`packages/core/admin/build/no-json.********.chunk.js`	5.48 kB	0 B
`packages/core/admin/build/pl-json.********.chunk.js`	13.2 kB	0 B
`packages/core/admin/build/pt-BR-json.********.chunk.js`	13.9 kB	0 B
`packages/core/admin/build/pt-json.********.chunk.js`	5.71 kB	0 B
`packages/core/admin/build/review-workflows-settings-create-view.********.chunk.js`	2.08 kB	0 B
`packages/core/admin/build/review-workflows-settings-edit-view.********.chunk.js`	2.28 kB	0 B
`packages/core/admin/build/review-workflows-settings-list-view.********.chunk.js`	5.63 kB	0 B
`packages/core/admin/build/ru-json.********.chunk.js`	21.6 kB	0 B
`packages/core/admin/build/runtime~main.********.js`	4.96 kB	0 B
`packages/core/admin/build/sa-json.********.chunk.js`	16.9 kB	0 B
`packages/core/admin/build/sk-json.********.chunk.js`	11.8 kB	0 B
`packages/core/admin/build/sso-settings-page.********.chunk.js`	1.92 kB	0 B
`packages/core/admin/build/sv-json.********.chunk.js`	14.1 kB	0 B
`packages/core/admin/build/th-json.********.chunk.js`	9.01 kB	0 B
`packages/core/admin/build/tr-json.********.chunk.js`	13.8 kB	0 B
`packages/core/admin/build/transfer-tokens-create-page.********.chunk.js`	259 B	0 B
`packages/core/admin/build/transfer-tokens-edit-page.********.chunk.js`	260 B	0 B
`packages/core/admin/build/transfer-tokens-list-page.********.chunk.js`	2.98 kB	0 B
`packages/core/admin/build/uk-json.********.chunk.js`	7.71 kB	0 B
`packages/core/admin/build/Upload_ConfigureTheView.********.chunk.js`	1.74 kB	0 B
`packages/core/admin/build/upload-settings.********.chunk.js`	3.08 kB	0 B
`packages/core/admin/build/upload-translation-ca-json.********.chunk.js`	2.48 kB	0 B
`packages/core/admin/build/upload-translation-de-json.********.chunk.js`	2.19 kB	0 B
`packages/core/admin/build/upload-translation-dk-json.********.chunk.js`	1.96 kB	0 B
`packages/core/admin/build/upload-translation-en-json.********.chunk.js`	2.58 kB	0 B
`packages/core/admin/build/upload-translation-es-json.********.chunk.js`	2.45 kB	0 B
`packages/core/admin/build/upload-translation-fr-json.********.chunk.js`	2.86 kB	0 B
`packages/core/admin/build/upload-translation-he-json.********.chunk.js`	1.84 kB	0 B
`packages/core/admin/build/upload-translation-it-json.********.chunk.js`	1.56 kB	0 B
`packages/core/admin/build/upload-translation-ja-json.********.chunk.js`	1.92 kB	0 B
`packages/core/admin/build/upload-translation-ko-json.********.chunk.js`	2.5 kB	0 B
`packages/core/admin/build/upload-translation-ms-json.********.chunk.js`	1.41 kB	0 B
`packages/core/admin/build/upload-translation-pl-json.********.chunk.js`	2.19 kB	0 B
`packages/core/admin/build/upload-translation-pt-BR-json.********.chunk.js`	1.61 kB	0 B
`packages/core/admin/build/upload-translation-pt-json.********.chunk.js`	1.61 kB	0 B
`packages/core/admin/build/upload-translation-ru-json.********.chunk.js`	2.02 kB	0 B
`packages/core/admin/build/upload-translation-sk-json.********.chunk.js`	2.58 kB	0 B
`packages/core/admin/build/upload-translation-th-json.********.chunk.js`	1.99 kB	0 B
`packages/core/admin/build/upload-translation-tr-json.********.chunk.js`	2.35 kB	0 B
`packages/core/admin/build/upload-translation-uk-json.********.chunk.js`	1.96 kB	0 B
`packages/core/admin/build/upload-translation-zh-Hans-json.********.chunk.js`	3.12 kB	0 B
`packages/core/admin/build/upload-translation-zh-json.********.chunk.js`	2.65 kB	0 B
`packages/core/admin/build/upload.********.chunk.js`	8.04 kB	0 B
`packages/core/admin/build/users-advanced-settings-page.********.chunk.js`	3.39 kB	0 B
`packages/core/admin/build/users-email-settings-page.********.chunk.js`	3.49 kB	0 B
`packages/core/admin/build/users-permissions-translation-ar-json.********.chunk.js`	1.51 kB	0 B
`packages/core/admin/build/users-permissions-translation-cs-json.********.chunk.js`	1.46 kB	0 B
`packages/core/admin/build/users-permissions-translation-de-json.********.chunk.js`	1.58 kB	0 B
`packages/core/admin/build/users-permissions-translation-dk-json.********.chunk.js`	1.92 kB	0 B
`packages/core/admin/build/users-permissions-translation-en-json.********.chunk.js`	1.81 kB	0 B
`packages/core/admin/build/users-permissions-translation-es-json.********.chunk.js`	2.05 kB	0 B
`packages/core/admin/build/users-permissions-translation-fr-json.********.chunk.js`	1.41 kB	0 B
`packages/core/admin/build/users-permissions-translation-id-json.********.chunk.js`	1.49 kB	0 B
`packages/core/admin/build/users-permissions-translation-it-json.********.chunk.js`	1.57 kB	0 B
`packages/core/admin/build/users-permissions-translation-ja-json.********.chunk.js`	1.53 kB	0 B
`packages/core/admin/build/users-permissions-translation-ko-json.********.chunk.js`	2.23 kB	0 B
`packages/core/admin/build/users-permissions-translation-ms-json.********.chunk.js`	1.27 kB	0 B
`packages/core/admin/build/users-permissions-translation-nl-json.********.chunk.js`	1.32 kB	0 B
`packages/core/admin/build/users-permissions-translation-pl-json.********.chunk.js`	2.11 kB	0 B
`packages/core/admin/build/users-permissions-translation-pt-BR-json.********.chunk.js`	1.21 kB	0 B
`packages/core/admin/build/users-permissions-translation-pt-json.********.chunk.js`	1.3 kB	0 B
`packages/core/admin/build/users-permissions-translation-ru-json.********.chunk.js`	2.75 kB	0 B
`packages/core/admin/build/users-permissions-translation-sk-json.********.chunk.js`	1.38 kB	0 B
`packages/core/admin/build/users-permissions-translation-sv-json.********.chunk.js`	2.01 kB	0 B
`packages/core/admin/build/users-permissions-translation-th-json.********.chunk.js`	2.01 kB	0 B
`packages/core/admin/build/users-permissions-translation-tr-json.********.chunk.js`	2.07 kB	0 B
`packages/core/admin/build/users-permissions-translation-uk-json.********.chunk.js`	1.75 kB	0 B
`packages/core/admin/build/users-permissions-translation-vi-json.********.chunk.js`	1.51 kB	0 B
`packages/core/admin/build/users-permissions-translation-zh-Hans-json.********.chunk.js`	2.19 kB	0 B
`packages/core/admin/build/users-permissions-translation-zh-json.********.chunk.js`	2.1 kB	0 B
`packages/core/admin/build/users-providers-settings-page.********.chunk.js`	5.48 kB	0 B
`packages/core/admin/build/users-roles-settings-page.********.chunk.js`	7.3 kB	0 B
`packages/core/admin/build/vi-json.********.chunk.js`	5.98 kB	0 B
`packages/core/admin/build/webhook-edit-page.********.chunk.js`	5.59 kB	0 B
`packages/core/admin/build/webhook-list-page.********.chunk.js`	3.14 kB	0 B
`packages/core/admin/build/zh-Hans-json.********.chunk.js`	17.2 kB	0 B
`packages/core/admin/build/zh-json.********.chunk.js`	15.2 kB	0 B
`packages/core/helper-plugin/build/helper-plugin.esm.js`	25.3 kB	+4 B (0%)
`packages/core/helper-plugin/build/helper-plugin.js`	23.3 kB	+4 B (0%)

_{compressed-size-action}

joshuaellis · 2023-08-08T07:39:43Z

Added test ✅

gu-stav

<3

strapi-bot · 2023-08-09T15:13:37Z

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/unable-to-set-date-field-to-null-via-admin-ui/30930/3

joshuaellis added source: core:helper-plugin pr: fix This PR is fixing a bug labels Aug 8, 2023

joshuaellis added this to the 4.12.3 milestone Aug 8, 2023

joshuaellis requested review from gu-stav, jhoward1994 and markkaylor August 8, 2023 07:13

joshuaellis self-assigned this Aug 8, 2023

vercel bot deployed to Preview – helper-plugin-storybook August 8, 2023 07:15 View deployment

markkaylor previously approved these changes Aug 8, 2023

View reviewed changes

gu-stav reviewed Aug 8, 2023

View reviewed changes

packages/core/helper-plugin/src/components/GenericInput.jsx Show resolved Hide resolved

fix: cannot clear date-field

1415dd4

joshuaellis dismissed markkaylor’s stale review via 1415dd4 August 8, 2023 07:39

joshuaellis force-pushed the fix/cannot-clear-date-field branch from a990b44 to 1415dd4 Compare August 8, 2023 07:39

joshuaellis requested review from gu-stav and markkaylor August 8, 2023 07:39

gu-stav approved these changes Aug 8, 2023

View reviewed changes

vercel bot deployed to Preview – helper-plugin-storybook August 8, 2023 07:43 View deployment

jhoward1994 approved these changes Aug 8, 2023

View reviewed changes

joshuaellis merged commit 2274e5e into main Aug 8, 2023

joshuaellis deleted the fix/cannot-clear-date-field branch August 8, 2023 08:27

This was referenced Aug 8, 2023

Error Field Date in entry #17151

Closed

Clearing DateTime field in Content Manager does not result in enabled Save button #17614

Closed

VitaliaSvirskaja mentioned this pull request Aug 9, 2023

Veranstaltungen TSC-Rot-Gold-Casino-Nurnberg-e-V/rgc-website#38

Closed

26 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: cannot clear date-field #17599

fix: cannot clear date-field #17599

Uh oh!

joshuaellis commented Aug 8, 2023 •

edited

Loading

Uh oh!

markkaylor left a comment

Uh oh!

Uh oh!

github-actions bot commented Aug 8, 2023 •

edited

Loading

Uh oh!

joshuaellis commented Aug 8, 2023

Uh oh!

gu-stav left a comment

Uh oh!

strapi-bot commented Aug 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

fix: cannot clear date-field #17599

fix: cannot clear date-field #17599

Uh oh!

Conversation

joshuaellis commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does it do?

Why is it needed?

How to test it?

Related issue(s)/PR(s)

Uh oh!

markkaylor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshuaellis commented Aug 8, 2023

Uh oh!

gu-stav left a comment

Choose a reason for hiding this comment

Uh oh!

strapi-bot commented Aug 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

joshuaellis commented Aug 8, 2023 •

edited

Loading

github-actions bot commented Aug 8, 2023 •

edited

Loading