Skip to content

Conversation

@diacu
Copy link
Contributor

@diacu diacu commented Sep 1, 2023

What does it do?

There's a typo, causing validateQuery to fail for queries containing media file references.

Why is it needed?

Fix the error Missing schema in validateQuery.

How to test it?

Query for any entity that has a media file relation field and include the file in the attributes.

Related issue(s)/PR(s)

fixes #17875

@derrickmehaffy derrickmehaffy added pr: fix This PR is fixing a bug source: plugin:graphql Source is plugin/graphql package labels Sep 1, 2023
Copy link
Contributor

@maccomaccomaccomacco maccomaccomaccomacco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressed.

derrickmehaffy added a commit that referenced this pull request Sep 1, 2023
Creating an internal branch to be able to release experimental
Copy link
Member

@Bassel17 Bassel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
A silly mistake from our side

@derrickmehaffy
Copy link
Member

I am generating an experimental version so users can test with it: https://github.com/strapi/strapi/actions/runs/6051019399

@derrickmehaffy
Copy link
Member

Experimental Version: 0.0.0-experimental.f0f8d365a96bb312d6f9e8f40d6cdd061b9a2892

Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the experimental and it works properly.

@derrickmehaffy derrickmehaffy merged commit b31c3c3 into strapi:main Sep 1, 2023
@derrickmehaffy derrickmehaffy added this to the 4.13.2 milestone Sep 1, 2023
@mauriciabad
Copy link

mauriciabad commented Sep 3, 2023

This issue should have been prevented with proper TypeScript setup...
And caught before making it into production with tests...

@LucaNerlich
Copy link

you are a live saver, thanks a lot!

@strapi-bot
Copy link

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/4-13-1-graphql-error-missing-schema-in-validatequery-for-images/31743/2

@lastnamearya
Copy link

Thanks for fixing this quick 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix This PR is fixing a bug source: plugin:graphql Source is plugin/graphql package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing schema in validateQuery after upgrading to v4.13.1

8 participants