Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing blocks attribute types #18187

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Add missing blocks attribute types #18187

merged 4 commits into from
Sep 27, 2023

Conversation

Convly
Copy link
Member

@Convly Convly commented Sep 27, 2023

What does it do?

  • Add the blocks attribute type and its related definition
  • Fix the Common.Schemas type (fix the broken link to dynamic type registries)

@Convly Convly added pr: fix This PR is fixing a bug source: typescript Source is related to TypeScript (typings, tooling, ...) labels Sep 27, 2023
@Convly Convly added this to the 4.14.0 milestone Sep 27, 2023
innerdvations
innerdvations approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@Convly Convly merged commit df9d17f into releases/4.14.0 Sep 27, 2023
9 of 13 checks passed
@Convly Convly deleted the fix/blocks-attribute-typings branch September 27, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerdvations innerdvations innerdvations approved these changes

@markkaylor markkaylor markkaylor approved these changes

Assignees
No one assigned
Labels
pr: fix This PR is fixing a bug source: typescript Source is related to TypeScript (typings, tooling, ...)
Projects
None yet
Milestone
4.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Convly @innerdvations @markkaylor