chore(generator): add runtime dir to gitignore #18978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaellis
added
pr: chore
|
We may want to keep the .cache in there just in case (won't hurt anything). |
dgrebb
added a commit
to dgrebb/dgrebb.com
that referenced
this pull request
Dec 6, 2023
dgrebb
added a commit
to dgrebb/dgrebb.com
that referenced
this pull request
Dec 6, 2023
gu-stav
approved these changes
Dec 11, 2023
I think on this occasion because it's there's already so many items in that list and this is for new projects, we can probably just leave it because it shouldn't exist. The only case I can think of is if someone upgrades and we mutate the .gitignore, but i don't think thats in scope of the tools 👀 |
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/auto-generated-files-to-git-or-not-to-git/35023/6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Why is it needed?
Related issue(s)/PR(s)