-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Add new LinkedIn opendid provider #19622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new LinkedIn opendid provider #19622
Conversation
85155fd to
f3c6217
Compare
|
@derrickmehaffy Can you take a look at this PR? I fixed the author email issue you flagged in #19610 with this new PR |
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/linkedin-provider-sign-in-issue/35841/4 |
|
Thanks @lswartsenburg for this PR. I need also this to be merged. |
|
@derrickmehaffy What is the best way to get this merged? |
f3c6217 to
24674e1
Compare
|
Deployment failed with the following error: |
|
+1 this is very much needed |
|
@innerdvations Do you think we can proceed with merging this? |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…trapi into linkedin_openid_provider
|
What is the progress of this pr when is it going to be merged? |
|
@pos1234 Im not getting a ton of responses from the maintainers and I've got no idea what the contributer-docs check is and why it's failing. As I've worked around the issue for my project, I am losing a bit of steam trying to get this merged. Happy for anyone else to re-submit a PR with these changes and take ownership. |
|
Hello, I have tried this PR and cannot make it work, it is missing the scope in the config & after manually changing those it just won't work. We have a working PR #20625 so I'll close this one |
|
@alexandrebodin lookedat your PR. It's backward incompatible with people not openid, so it will break a lot of setups |
This PR is based on #15216
This PR is a retry of #19610 with an updated commit email
What does it do?
This PR adds support for the new LinkedIn OpenID Authentication (https://www.linkedin.com/developers/news/featured-updates/openid-connect-authentication)
Why is it needed?
All new LinkedIn apps are now forced to use the new OpenID standard and will therefore have to use this provider.
How to test it?
Related issue(s)/PR(s)