Skip to content

Conversation

@lswartsenburg
Copy link

@lswartsenburg lswartsenburg commented Feb 27, 2024

This PR is based on #15216

This PR is a retry of #19610 with an updated commit email

What does it do?

This PR adds support for the new LinkedIn OpenID Authentication (https://www.linkedin.com/developers/news/featured-updates/openid-connect-authentication)

Why is it needed?

All new LinkedIn apps are now forced to use the new OpenID standard and will therefore have to use this provider.

How to test it?

image

Related issue(s)/PR(s)

@lswartsenburg
Copy link
Author

@derrickmehaffy Can you take a look at this PR? I fixed the author email issue you flagged in #19610 with this new PR

@strapi-bot
Copy link

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/linkedin-provider-sign-in-issue/35841/4

@Melak12
Copy link

Melak12 commented Mar 13, 2024

Thanks @lswartsenburg for this PR. I need also this to be merged.

@lswartsenburg
Copy link
Author

@derrickmehaffy What is the best way to get this merged?

@lswartsenburg lswartsenburg force-pushed the linkedin_openid_provider branch from f3c6217 to 24674e1 Compare March 20, 2024 17:59
@vercel
Copy link

vercel bot commented Mar 20, 2024

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@lswartsenburg lswartsenburg marked this pull request as draft March 20, 2024 18:13
@lswartsenburg lswartsenburg marked this pull request as ready for review March 20, 2024 18:13
@martin-kolarov
Copy link

+1 this is very much needed

@innerdvations innerdvations added pr: feature This PR adds a new feature source: providers Source is a provider package community Changes and fixes created by community members labels Mar 26, 2024
@lswartsenburg
Copy link
Author

@innerdvations Do you think we can proceed with merging this?

@vercel
Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ❌ Failed (Inspect) Apr 29, 2024 3:42pm

@pos1234
Copy link

pos1234 commented Apr 24, 2024

What is the progress of this pr when is it going to be merged?

@lswartsenburg
Copy link
Author

lswartsenburg commented Apr 29, 2024

@pos1234 Im not getting a ton of responses from the maintainers and I've got no idea what the contributer-docs check is and why it's failing.

As I've worked around the issue for my project, I am losing a bit of steam trying to get this merged. Happy for anyone else to re-submit a PR with these changes and take ownership.

@alexandrebodin
Copy link
Member

Hello, I have tried this PR and cannot make it work, it is missing the scope in the config & after manually changing those it just won't work.

We have a working PR #20625 so I'll close this one

@lswartsenburg
Copy link
Author

@alexandrebodin lookedat your PR. It's backward incompatible with people not openid, so it will break a lot of setups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Changes and fixes created by community members pr: feature This PR adds a new feature source: plugin:users-permissions Source is plugin/users-permissions package

Projects

Status: Fixed/Shipped

Development

Successfully merging this pull request may close these issues.

7 participants