fix: linkedin provider #20625
fix: linkedin provider #20625
Conversation
alexandrebodin
added
source: plugin:users-permissions
|
Backward incompatible with people not on openid. Please don't merge this. It will cause a lot of problems for people that have linked auth setup preciously |
alexandrebodin
added
the
flag: don't merge
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@lswartsenburg If you have any suggestion that can work let us know. right now it was the only way we could make it work |
Yeah it was the only way this could work. Considering linkedin connection is currently broken anyway I don't see how this would be an issue to change it as nobody can make it work right now because they removed the old endpoints & access |
|
@alexandrebodin just create a new provider like the original PR to continue supporting the legacy client until it's officially deprecated |
This comment was marked as abuse.
This comment was marked as abuse.
Grant doesn't work like this sadly, you cannot just add providers with custom names. They have to match with what grant knows. This is why your original PR didn't work and was getting Grant missconfiguration errors. The old provider is not working so who is this keeping support for ? |
|
@lswartsenburg I understand you might be frustrated but your comment is in violation of our CoC: https://github.com/strapi/strapi/blob/develop/CODE_OF_CONDUCT.md It's fine to disagree with us, but we expect users to be civil on our repos. This will be your only warning, the next one will be a ban from our repos and community platforms. |
|
@derrickmehaffy fair I'll tune it down. But I hope you also realize how uncivil it is to leave open source contributors hanging for months despite repeated outreach (including to yourself). |
|
@lswartsenburg If you are willing to help us get this PR merged with your suggestion and make it work that would be very helpful. |
|
@alexandrebodin happy to, but I realistically won't get to it till Friday (sorry, I'm responding on my phone here because I'm so strapped for time). And yeah, you can see on the screenshot of the original PR that the callback working fine. I should have added a UI pic too, but I guess I forgot. |
Ok so either sth changed on linkedin or I missconfigured linkedIn somehow. No rush we are focus on the next major right now and have barely time to do anything else |
|
Yeah Strapi 5 is eating up almost all of our time so community PRa have been lower priority. We hope to change that later this year as we know we haven't been great it. Any help you can give us would be great thank you. |
|
FYi I think I figured out the missing piece: simov/grant#220 We need to provide all the auth options when adding an unknown provider to grant so we could duplicate the base linkedin config. |
|
Thank you for taking my pr, @alexandrebodin |
you are welcome, it was just missing that openid scope. We have to figure out if the old api is still usable somhow or if we can just fix the main provider. it's unclear to me if they actually just deprecated it or completely dropped it and I can't find any doc for it |
Same , I can't find any docs related to changes. |
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/strapi-wont-update-providers/40292/2 |
|
Any update on when this is going to be merged |
|
This is staled right now, If you read the discussion you might be able to help us and share some insights @MannJadwani |
|
https://learn.microsoft.com/en-us/linkedin/consumer/integrations/self-serve/sign-in-with-linkedin-v2 I think they changed it , |
|
Considering this is currently broken for current & previous users I don't see how this change could be a BC 🤔 -> The question is "Is the v1 still accessible ?". I release an experimental version |
|
Hey @bn-pshulga did you get a chance to test the experimental version ? |
|
Sorry @alexandrebodin , didn't have time to test. |
|
@bn-pshulga No worries I'll leave it here for now if someone with linkedin access can test it sometime too |
|
This fix is needed, |
@oismaelash I could not find a solution to have a second linkeding config, if you want to try sth feel free to start from this PR to validate it's working for you. |
|
@alexandrebodin I work on this bug, Image preview: WIP here: |
|
Nice one @oismaelash, let us know if/when you've cracked it or we'll keep this thread posted if we come back to this soon 🙏 |
Next week, I release a PR |
What does it do?
Fix linkedin auth provider in U&P