Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bookshelf Upload Plugin findOne giving 500 error #2824

Merged
merged 2 commits into from Feb 17, 2019
Merged

Fix bookshelf Upload Plugin findOne giving 500 error #2824

merged 2 commits into from Feb 17, 2019

Conversation

derrickmehaffy
Copy link
Member

@derrickmehaffy derrickmehaffy commented Feb 13, 2019 •
edited

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix #issueNumber
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres

Description:

Thanks to @crashlab for providing the quick fix

Noticed an issue when querying the upload plugin for files by ID:

0|capi-dev  | [2019-02-13T16:22:10.770Z] debug GET /upload/files (137 ms)
0|capi-dev  | { Error: ER_BAD_FIELD_ERROR: Unknown column 'upload_file._id' in 'where clause'

While using bookshelf.

@lauriejim lauriejim self-requested a review February 14, 2019 16:25
@lauriejim lauriejim self-assigned this Feb 14, 2019
@lauriejim lauriejim added pr: 馃悰 Bug fix source: core:content-manager Source is core/content-manager package labels Feb 14, 2019
lauriejim
lauriejim approved these changes Feb 17, 2019
View reviewed changes
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho yeah you are right!
Thank you for this fix.

@lauriejim lauriejim added this to the 3.0.0-alpha.24 milestone Feb 17, 2019
@lauriejim lauriejim merged commit c53d445 into master Feb 17, 2019
@lauriejim lauriejim deleted the fix/bookshelf-upload-query-findone branch February 17, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauriejim lauriejim lauriejim approved these changes

Assignees

@lauriejim lauriejim

Labels
source: core:content-manager Source is core/content-manager package
Projects
None yet
Milestone
3.0.0-alpha.24
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@derrickmehaffy @lauriejim