Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SQL Mutation Updates #2943

Merged
merged 2 commits into from Mar 7, 2019
Merged

Fix for SQL Mutation Updates #2943

merged 2 commits into from Mar 7, 2019

Conversation

derrickmehaffy
Copy link
Member

Description:

This is a temporary fix for Bookshelf based GraphQL Update Mutations until the following PR is merged: #2452

Thank you to @azamuddin for the fix provided here: #2530 (comment)

@lauriejim if this could be included in the v25 release to get mutations working while more testing is done on the Deep Filtering PR that would be great

My PR is a:

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

@lauriejim lauriejim self-assigned this Mar 7, 2019
@lauriejim lauriejim added pr: 馃悰 Bug fix source: core:content-manager Source is core/content-manager package labels Mar 7, 2019
@lauriejim lauriejim added this to the 3.0.0-alpha.25 milestone Mar 7, 2019
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lauriejim lauriejim changed the title Temporary fix for SQL Mutation Updates Fix for SQL Mutation Updates Mar 7, 2019
@lauriejim lauriejim merged commit a987565 into master Mar 7, 2019
@lauriejim lauriejim deleted the fix/2530 branch March 7, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL mutation error column "_id" on SQL
2 participants