Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim content builder model attributes #2994

Merged
merged 2 commits into from Apr 9, 2019

Conversation

Projects
None yet
3 participants
@Getriax
Copy link
Contributor

commented Mar 18, 2019

Description:

This PR fixes the issue with model created by the content builder. The lack of trimmed attributes was reported in #2881.

I have implemented the deep trim of the string values in the object. AFAIK the model attributes should not contain white spaces.

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix #2881
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin content-type-builder

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite
@soupette

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

We need to test this PR after merging #2954, if you want to add it to the codebase

@lauriejim lauriejim changed the title Trim content builder model attributes -> Issue #2881 Trim content builder model attributes Apr 4, 2019

@lauriejim lauriejim added this to the 3.0.0-alpha.next milestone Apr 4, 2019

@lauriejim lauriejim requested a review from soupette Apr 9, 2019

@soupette
Copy link
Member

left a comment

LGTM

@lauriejim lauriejim merged commit b31d36b into strapi:master Apr 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.