Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix front-end generators plugin #3030

Merged
merged 1 commit into from Mar 28, 2019

Conversation

Projects
None yet
2 participants
@soupette
Copy link
Member

commented Mar 26, 2019

Description:

The front-end selectors for the generate-plugin package were trying to get an undefined key so which was breaking the admin.

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix #3013
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • [] Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite
@lauriejim
Copy link
Member

left a comment

LGTM!

Thank you @soupette for this fix.

@lauriejim lauriejim added this to the 3.0.0-alpha.next milestone Mar 28, 2019

@lauriejim lauriejim self-assigned this Mar 28, 2019

@lauriejim lauriejim merged commit a2b537e into master Mar 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lauriejim lauriejim deleted the fix/generators branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.