Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix languages in settings manager #3038

Merged
merged 3 commits into from Mar 29, 2019

Conversation

Projects
None yet
2 participants
@soupette
Copy link
Member

commented Mar 27, 2019

Description:

The old react select caused an error when trying to open the add new language modal. This PR removes the old react select and use a simple select instead

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix #1325
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin settings manager

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

@soupette soupette requested a review from lauriejim Mar 27, 2019

@lauriejim lauriejim self-assigned this Mar 29, 2019

@lauriejim lauriejim added this to the 3.0.0-alpha.next milestone Mar 29, 2019

@lauriejim lauriejim merged commit 1845353 into master Mar 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lauriejim lauriejim deleted the stm/remove-react-select branch Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.