Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix big integer support on GraphQL #3090

Merged
merged 7 commits into from Apr 10, 2019

Conversation

Projects
None yet
4 participants
@derrickmehaffy
Copy link
Contributor

commented Apr 5, 2019

Description:

Fix support for big integer values on GraphQL using the following module: https://www.npmjs.com/package/graphql-type-long

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix #3084
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite
@alexandrebodin

This comment has been minimized.

Copy link
Collaborator

commented Apr 5, 2019

Looks good to me.

Can you had some tests ?

@derrickmehaffy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

Looks good to me.

Can you had some tests ?

I'll give it my best shot after I test manually

@derrickmehaffy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

Looks good so far on MySQL:
image

derrickmehaffy added some commits Apr 5, 2019

@derrickmehaffy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

@alexandrebodin Ready for review

@derrickmehaffy derrickmehaffy changed the title [Needs Testing] Fix big integer support on GraphQL [Ready for Review] Fix big integer support on GraphQL Apr 5, 2019

@derrickmehaffy derrickmehaffy added this to 馃えTo check in 馃Cooking Apr 5, 2019

@Aurelsicoko

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2019

LGTM, not sure about the tests though... (cc @alexandrebodin)

@derrickmehaffy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

LGTM, not sure about the tests though... (cc @alexandrebodin)

I hate writing tests @Aurelsicoko 馃ぃ

@lauriejim lauriejim added this to the 3.0.0-alpha.next milestone Apr 10, 2019

@lauriejim lauriejim removed this from 馃えTo check in 馃Cooking Apr 10, 2019

@lauriejim lauriejim changed the title [Ready for Review] Fix big integer support on GraphQL Fix big integer support on GraphQL Apr 10, 2019

@lauriejim lauriejim merged commit 35681c1 into master Apr 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lauriejim lauriejim deleted the fix/#3084 branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.