Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media preview list #3945

Merged
merged 19 commits into from Sep 16, 2019

Conversation

@virginieky
Copy link
Contributor

virginieky commented Sep 10, 2019

Description of what you did:

Media Preview List display and configuration in the content manager

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite
virginieky and others added 12 commits Aug 29, 2019
@virginieky virginieky requested a review from soupette Sep 10, 2019
@virginieky virginieky changed the base branch from develop to master Sep 10, 2019
{getDisplayedValue(
{get(schema, ['attributes', header.name, 'type']) !== 'media' ? (
<Truncate>
<Truncated>

This comment has been minimized.

Copy link
@soupette

soupette Sep 10, 2019

Member

And use it here

<Truncate>
   <Truncated>{memoizedDisplayedValue(header.name)}</Truncated>
</Truncate>
@virginieky virginieky requested a review from soupette Sep 11, 2019
virginieky added 2 commits Sep 11, 2019
Copy link
Member

soupette left a comment

LGTM

@virginieky virginieky changed the title Media preview list [WIP] Media preview list Sep 13, 2019
virginieky added 2 commits Sep 13, 2019
@virginieky virginieky changed the title [WIP] Media preview list Media preview list Sep 13, 2019
@virginieky virginieky requested a review from soupette Sep 13, 2019
Copy link
Member

soupette left a comment

LGTM

@alexandrebodin alexandrebodin merged commit 938fe68 into master Sep 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexandrebodin alexandrebodin deleted the features/media-preview branch Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.