Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node-sass in the administration panel #4122

Merged
merged 161 commits into from Oct 22, 2019

Conversation

@soupette
Copy link
Member

soupette commented Sep 27, 2019

Description of what you did:

This PR removes node-sass which means that users will have to migrate all the scss files to styled-components.

Fixes:

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite
virginieky and others added 30 commits Sep 9, 2019
鈥ts/documentation
soupette and others added 12 commits Oct 15, 2019
Update image-webpack-loader configuration
Fix UI
Copy link
Contributor

virginieky left a comment

LGTM

@alexandrebodin alexandrebodin added this to the 3.0.0-beta.18 milestone Oct 22, 2019
@alexandrebodin alexandrebodin changed the title Remove sass in the administration panel and other improvements Remove node-sass in the administration panel. no optim in dev mode Oct 22, 2019
@alexandrebodin alexandrebodin changed the title Remove node-sass in the administration panel. no optim in dev mode Remove node-sass in the administration panel Oct 22, 2019
Copy link
Collaborator

alexandrebodin left a comment

LGTM

@alexandrebodin alexandrebodin merged commit ef6e68b into master Oct 22, 2019
2 checks passed
2 checks passed
ci/gitlab/develop Pipeline passed on GitLab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.