Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image url when using a third party #4191

Merged
merged 1 commit into from Oct 5, 2019

Conversation

@FailedSitcom
Copy link
Contributor

FailedSitcom commented Oct 4, 2019

鈥ngular upload

Description of what you did:

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite
@lauriejim lauriejim changed the title only add backend host as prefix if local server upload when getting s鈥 Fix image url when using a third party Oct 5, 2019
Copy link
Member

lauriejim left a comment

Thank you for this fix.
LGTM!
@FailedSitcom , I appreciate your contribution.

@lauriejim lauriejim added this to the 3.0.0-beta.17 milestone Oct 5, 2019
@lauriejim lauriejim merged commit 8e2a6ec into strapi:master Oct 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.