Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forgot password url #4222

Merged
merged 4 commits into from Oct 15, 2019

Conversation

@lauriejim
Copy link
Member

lauriejim commented Oct 9, 2019

Description of what you did:

This Pull Request fix #549.
Now the reset password url page have to be set in the Users & Permissions advanced settings.

So all people that implemented this features have to set in the admin panel their reset password page.
And remove the value from their forgot password request.

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite
Copy link
Member

soupette left a comment

The code is ok but can you add the fr translations?

@lauriejim lauriejim requested review from alexandrebodin and soupette Oct 15, 2019
lauriejim and others added 2 commits Oct 15, 2019
Copy link
Collaborator

alexandrebodin left a comment

LGTM

@alexandrebodin alexandrebodin added this to the 3.0.0-beta.17 milestone Oct 15, 2019
@alexandrebodin alexandrebodin merged commit 71c4745 into master Oct 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexandrebodin alexandrebodin deleted the fix/forgot-password-url branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.