Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup race condition by disabling reload when writing jwt.json #4246

Merged
merged 1 commit into from Oct 14, 2019

Conversation

@alexandrebodin
Copy link
Collaborator

alexandrebodin commented Oct 14, 2019

Description of what you did:

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite
@alexandrebodin alexandrebodin added this to the 3.0.0-beta.17 milestone Oct 14, 2019
@alexandrebodin alexandrebodin requested a review from lauriejim Oct 14, 2019
@alexandrebodin alexandrebodin changed the title Disable reload on jwt.json creation to fix startup race condition fix startup race condition by disabling reload when writing jwt.json Oct 14, 2019
@alexandrebodin alexandrebodin changed the title fix startup race condition by disabling reload when writing jwt.json Fix startup race condition by disabling reload when writing jwt.json Oct 14, 2019
Copy link
Member

lauriejim left a comment

LGTM!

@alexandrebodin alexandrebodin merged commit 656343d into master Oct 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexandrebodin alexandrebodin deleted the fix/jwt-restarts-not-wanted branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.