Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix groups creation/update not working with null groups #4281

Merged
merged 2 commits into from Oct 18, 2019

Conversation

@alexandrebodin
Copy link
Collaborator

alexandrebodin commented Oct 18, 2019

Description of what you did:

Fix ##4265

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite
@alexandrebodin alexandrebodin added this to the 3.0.0-beta.17.2 milestone Oct 18, 2019
@alexandrebodin alexandrebodin requested a review from lauriejim Oct 18, 2019
@alexandrebodin alexandrebodin changed the title Fix groups creation/update not working when null group bofre in the loop Fix groups creation/update not working with null groups Oct 18, 2019
Copy link
Member

lauriejim left a comment

LGTM

@alexandrebodin alexandrebodin merged commit 99a5d9e into master Oct 18, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@alexandrebodin alexandrebodin deleted the fix/groups-issue-interupting branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.