Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty default on group attributes #4305

Merged
merged 2 commits into from Oct 22, 2019

Conversation

@slatham
Copy link
Contributor

slatham commented Oct 21, 2019

Description of what you did:

Fix issue #4138 - Cannot remove default value for number type in group.

Fixed by converting the zero-length string that is being submitted (from the frontend) to undefined. This removes the default attribute and it then doesn't fail the validation checks as per issue #4138.

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite
Copy link
Collaborator

alexandrebodin left a comment

Thanks for the fix.

@alexandrebodin alexandrebodin changed the title Fix for issue #4138 - Cannot remove default value for number type in group Allow empty default on group attributes Oct 22, 2019
@alexandrebodin alexandrebodin added this to the 3.0.0-beta.17.3 milestone Oct 22, 2019
@alexandrebodin alexandrebodin merged commit 15d97a2 into strapi:master Oct 22, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.