Update Providers.js for Facebook Auth to prevent new user to be blocked on registration #5000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edeuxk can you please use the PR template, and provide a descriptive title? There are parts of the template that are used to automatically generate the change logs for releases |
edeuxk
changed the title
|
HI @edeuxk, Thank you for your contribution. I'm closing this PR as we discussed in the associated issue for now. |
|
This pull request has been mentioned on Strapi Community. There might be relevant details there: https://forum.strapi.io/t/global-authenticate-issue-facebook-google-local-provider-4998/1453/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what you did:
Issue: https://github.com/strapi/strapi/issues/4998
So I've replaced the facebook callback username by user.name + user.id.
It prevent new users with an already known name to be blocked as registration using Facebook Auth.
Since you only use the user email to find a user, it won't give any bugs or incorrect login attempts in the future
https://github.com/strapi/strapi/blob/master/packages/strapi-plugin-users-permissions/services/Providers.js#L44
const users = await strapi.query('user', 'users-permissions').find({ email: profile.email, });My PR is a:
Main update on the:
Manual testing done on the following databases: