Skip to content

Conversation

@ascension
Copy link

Description of what you did:

Based on the discussion in #6550 I implemented:
Added a new config option loader.extensions to allow core api to load additional files.
Added a new example project that uses Typescript.
Updated config docs to include loader.extensions

dependabot bot and others added 10 commits September 8, 2020 13:48
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 10.4.8 to 11.0.2.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v10.4.8...v11.0.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
Bumps [axios-mock-adapter](https://github.com/ctimmerm/axios-mock-adapter) from 1.17.0 to 1.18.2.
- [Release notes](https://github.com/ctimmerm/axios-mock-adapter/releases)
- [Changelog](https://github.com/ctimmerm/axios-mock-adapter/blob/master/CHANGELOG.md)
- [Commits](ctimmerm/axios-mock-adapter@v1.17.0...v1.18.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
Signed-off-by: Poluektov Dmitriy <dmitry.a@kr.digital>
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
Bumps [@fortawesome/free-solid-svg-icons](https://github.com/FortAwesome/Font-Awesome) from 5.12.1 to 5.14.0.
- [Release notes](https://github.com/FortAwesome/Font-Awesome/releases)
- [Changelog](https://github.com/FortAwesome/Font-Awesome/blob/master/CHANGELOG.md)
- [Commits](FortAwesome/Font-Awesome@5.12.1...5.14.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #7803 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7803   +/-   ##
=======================================
  Coverage   32.71%   32.71%           
=======================================
  Files        1194     1194           
  Lines       12965    12965           
  Branches     1279     1279           
=======================================
  Hits         4241     4241           
  Misses       7884     7884           
  Partials      840      840           
Flag Coverage Δ
#front 24.81% <ø> (ø)
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...min/admin/src/containers/ProfilePage/utils/form.js 100.00% <ø> (ø)
.../admin/src/containers/Users/EditPage/utils/form.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49ce464...164c71e. Read the comment docs.

@alexandrebodin
Copy link
Member

Hi, I see a lot of unwanted commits in your branch history :) Would you mind cleaning it up so the diff only contains your changes ;)

ascension and others added 5 commits September 18, 2020 09:27
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
@ascension ascension changed the base branch from master to fix/7699 September 18, 2020 15:39
@ascension ascension changed the base branch from fix/7699 to master September 18, 2020 15:39
Jerrod Bunce and others added 5 commits September 18, 2020 09:45
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 10.4.8 to 11.0.2.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v10.4.8...v11.0.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jerrod Bunce <jerrod.bunce@us.pwc.com>
@alexandrebodin
Copy link
Member

Hey, sorry but your PR history is still not clean :/

@alexandrebodin
Copy link
Member

Hi @ascension still seeing a weird history here :)

@ascension
Copy link
Author

Hi @ascension still seeing a weird history here :)

@alexandrebodin I will try to get this cleaned up this week

@derrickmehaffy
Copy link
Member

This pull request has been mentioned on Strapi Community. There might be relevant details there:

https://forum.strapi.io/t/strapi-integration-with-other-typescript-aplications-in-a-monorepo/1104/2

@strapi-cla
Copy link

strapi-cla commented Nov 30, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 5 committers have signed the CLA.

✅ alexandrebodin
✅ ascension
❌ Jerrod Bunce
❌ Ashot-KR
❌ lauriejim


Jerrod Bunce seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alexandrebodin alexandrebodin added the source: core:strapi Source is core/strapi package label Dec 4, 2020
@sapkra
Copy link
Contributor

sapkra commented Jan 9, 2021

@ascension Any update?

@ascension
Copy link
Author

ascension commented Jan 9, 2021

@ascension Any update?

@sapkra Opened a new PR #9076

@ascension ascension closed this Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

source: core:strapi Source is core/strapi package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants