Skip to content

Support node v14 + CI refactor #8226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 15, 2020
Merged

Support node v14 + CI refactor #8226

merged 6 commits into from
Oct 15, 2020

Conversation

@alexandrebodin
Copy link
Member

@alexandrebodin alexandrebodin commented Oct 7, 2020 •
edited
Loading

Signed-off-by: Alexandre Bodin bodin.alex@gmail.com

Description of what you did:

  • Refactor CI to use github actions
  • Test against node 14
  • Bypass apollo-server graphql-upload to make it work for node 14

@alexandrebodin alexandrebodin force-pushed the chore/node-14 branch 6 times, most recently from e188f32 to 44bf802 Compare October 7, 2020 13:51
derrickmehaffy
derrickmehaffy reviewed Oct 7, 2020
View reviewed changes
@alexandrebodin alexandrebodin force-pushed the chore/node-14 branch 23 times, most recently from 9a00e20 to a499a4a Compare October 7, 2020 17:20
@Convly Convly self-assigned this Oct 14, 2020
@alexandrebodin alexandrebodin force-pushed the chore/node-14 branch 3 times, most recently from 8b4cd8d to ec59922 Compare October 14, 2020 15:04
@derrickmehaffy
Copy link
Member

derrickmehaffy commented Oct 14, 2020 •
edited
Loading

Manual testing done on the tracking issue: #7921 (comment)

Any issues encountered on any OS will almost certainly be missing dependencies on the users system.
Used 7 different OSes on 7 isolated Virtual machines + my work mac and encountered no issues except with missing stuff for sharp. (And ARM CPUs but that's an upstream problem)

@alexandrebodin alexandrebodin force-pushed the chore/node-14 branch 6 times, most recently from 8254cd5 to ab19bed Compare October 14, 2020 16:13
@alexandrebodin
Use local actions
4bcce63 
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
@alexandrebodin alexandrebodin requested a review from Convly October 14, 2020 17:27
Convly
Convly previously approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👀

@alexandrebodin
Fix code factor
d450937 
Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
@alexandrebodin alexandrebodin merged commit 435b294 into master Oct 15, 2020
@alexandrebodin alexandrebodin deleted the chore/node-14 branch October 15, 2020 10:40
@lauriejim
Copy link
Contributor

This pull request has been mentioned on Strapi Community. There might be relevant details there:

https://forum.strapi.io/t/new-release-strapi-v3-2-4-security-fix/509/1

This was referenced Mar 10, 2021
Open
Open
This was referenced Mar 18, 2021
Closed
Closed
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
@renovate renovate bot mentioned this pull request Jun 14, 2021
Open
1 task
@songshansitulv songshansitulv mentioned this pull request Nov 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derrickmehaffy derrickmehaffy derrickmehaffy left review comments

@Convly Convly Convly left review comments

+1 more reviewer

@petersg83 petersg83 petersg83 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Convly Convly

Labels

issue: enhancement Issue suggesting an enhancement to an existing feature source: core:strapi Source is core/strapi package

Projects

None yet

Milestone

3.2.4

Development

Successfully merging this pull request may close these issues.

7 participants

@alexandrebodin @derrickmehaffy @abdonrd @lauriejim @petersg83 @Convly