New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds warnings and workarounds for Brotli performance in koa-compress #8261
Adds warnings and workarounds for Brotli performance in koa-compress #8261
Conversation
Codecov Report
@@ Coverage Diff @@
## documentation #8261 +/- ##
==================================================
+ Coverage 19.14% 33.04% +13.90%
==================================================
Files 855 1219 +364
Lines 11933 13573 +1640
Branches 1898 1348 -550
==================================================
+ Hits 2284 4485 +2201
- Misses 8100 8206 +106
+ Partials 1549 882 -667
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of what you did:
Added notes about gzip performance via koa-compress' default Brotli settings and a recommendation to disable Brotli on Heroku. These changes were prompted by the discussion in #7439 (comment) after experiencing extremely long response times on Heroku for the Admin panel javascript assets.