Jump to conversation
Unresolved conversations (1)
@derrickmehaffy derrickmehaffy Oct 13, 2020
And a symbol no?
packages/strapi-admin/services/user.js
Resolved conversations (9)
@Convly Convly Oct 14, 2020
Simple question: Why prefering the use of .`catch(expect)` instead of `expect().toThrow/toThrowError()` ?
Outdated
...api-admin/services/__tests__/user.test.js
alexandrebodin
Alexandre BODIN
@Convly Convly Oct 14, 2020
I'm being picky here, but can't you just do `updateById(user.id, { password });`, it's only one character more than `userId` but one line shorter too :man_shrugging:
Outdated
packages/strapi-admin/services/user.js
alexandrebodin
Alexandre BODIN
@Convly Convly Oct 14, 2020
Why can't we just use/re-format the yup error? This way it would allows us to only keep one validator up-to-date as a source of thruth.
packages/strapi-admin/services/user.js
alexandrebodin
Alexandre BODIN
@Convly Convly Oct 14, 2020
"User's password successfully reset" ?
packages/strapi/lib/commands/admin-reset.js
alexandrebodin
Alexandre BODIN
@Convly Convly Oct 14, 2020
Can't we assume that if the process isn't confirmed, then the cli command has failed? (thus `process.exit(1)`)?
packages/strapi/lib/commands/admin-reset.js
alexandrebodin
Alexandre BODIN
@Convly Convly Oct 14, 2020
Just a question here: Why did you make the choice to error/exit the process if one of the information is missing instead of just asking it to complete the command?
packages/strapi/lib/commands/admin-reset.js
Convly alexandrebodin
Jean-Sébastien Herbaux and Alexandre BODIN
@Convly Convly Oct 14, 2020
According to the last comment, it might be interesting to create a folder structure to match the scopes of the commands (eg: admin/user/reset-password)
packages/strapi/lib/commands/admin-reset.js
alexandrebodin
Alexandre BODIN
@Convly Convly Oct 14, 2020
Suggestion: Not sure about the name though. We don't mention the term `user` anywhere. `admin` can refer to many things, in the future `admin:reset-password` could be something else, no? What about `admin:user:reset-password` or `admin:user:reset` to indicates the different nested scopes?
Outdated
packages/strapi/bin/strapi.js
@Convly Convly Oct 14, 2020
Missing uppercase `O` for `output` (consistency with other options)
Outdated
packages/strapi/bin/strapi.js
alexandrebodin
Alexandre BODIN