Handle duplicate entry error

[jozefcipa]

What does it do?

This PR handles duplicate errors occurred on unique columns in the database and shows a user-friendly message, instead of a raw database error.

Before

After

Fixes #6915, #8664

[codecov]

Codecov Report

Merging #8367 (3d605a7) into master (5bbb8e6) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8367      +/-   ##
==========================================
- Coverage   34.64%   34.64%   -0.01%     
==========================================
  Files        1308     1308              
  Lines       14431    14437       +6     
  Branches     1432     1432              
==========================================
+ Hits         5000     5001       +1     
- Misses       8517     8522       +5     
  Partials      914      914              

Flag	Coverage Δ
front	26.04% <ø> (-0.01%)	⬇️
unit	54.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...kages/strapi-admin/admin/src/translations/index.js	100.00% <0.00%> (ø)
...trapi-plugin-email/admin/src/translations/index.js	0.00% <0.00%> (ø)
...rapi-plugin-upload/admin/src/translations/index.js	0.00% <0.00%> (ø)
...in-content-manager/admin/src/translations/index.js	0.00% <0.00%> (ø)
...-users-permissions/admin/src/translations/index.js	0.00% <0.00%> (ø)
...ntent-manager/admin/src/components/Search/index.js	0.00% <0.00%> (ø)
...ntent-type-builder/admin/src/translations/index.js	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35835fd...3d605a7. Read the comment docs.

[derrickmehaffy]

Not sure why the @strapi/documentation got tagged for review, but if it's related to the translations, they look fine to me.

[strapi-cla]

All committers have signed the CLA.

[alexandrebodin]

Hi ! @jozefcipa this looks really promising :) can you fix the conflicts on your PR ?

[jozefcipa]

@alexandrebodin fixed!

[gddid]

any update for this ? @jozefcipa

[jozefcipa]

@gddid it is ready and waiting for a review. cc: @alexandrebodin

[alexandrebodin]

can you compose the function instead of adding a try catch ?

// keep old implementation
const create = () => {}


return {
  create: wrapErrors(create),
  update: wrapErrors(update)
}


// utils
// keep your impl
const handleError = () => {}

// add a composable function
const wrapErrors = fn => async (...args) => {
  try {
    return fn(...args)
  } catch (error) {
    return handleErrors(error)
  }
}

[jozefcipa]

I think I finally fixed the tests but when I went to test the fix in the administration I noticed it might be already being handled (strapi-plugin-content-manager/utils/wrap-bad-request.js:13) 🤔
So now I'm not sure if it makes sense to merge this PR.

[alexandrebodin]

I think I finally fixed the tests but when I went to test the fix in the administration I noticed it might be already being handled (strapi-plugin-content-manager/utils/wrap-bad-request.js:13) 🤔
So now I'm not sure if it makes sense to merge this PR.

What you did will give the right error when using the queries programmaticaly which the wrap-bad-request doesn't do so still worth it :)

[alexandrebodin]

LGTM, Thank you fro this contribution 💯

[derrickmehaffy]

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/new-release-strapi-v3-4-5/2446/1

[derrickmehaffy]

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/custom-error-handling/199/5